feat: Implement create post functionality#1
Merged
Conversation
Implements business logic in the `PostServiceImpl` to prevent the creation of posts with invalid titles. - Adds a validation check to ensure that the post title is not null, empty, or blank (contains only whitespace). - If the title is invalid, the service returns `Optional.empty()` immediately and does not make a downstream call to the API client. The unit tests have been updated to cover these validation scenarios: - Refactored the null and blank title tests into a single, more thorough parameterized test using `@NullAndEmptySource` and `@ValueSource`. - Added a new test to confirm that the service correctly handles and propagates failures from the API client.
Implements the `createPost` method in the `JsonPlaceholderClient` to perform a live HTTP POST request. - Serializes the `Post` object to a JSON string for the request body. - Sets the `Content-Type: application/json` header, which is required for the API to correctly interpret the request. - Checks for a `201 Created` status code to confirm a successful creation. - Adds a corresponding integration test to `PostApiTests` to verify the live API call and response parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Complete Functionality for Creating New Posts
This pull request introduces the complete functionality for creating a new post, covering the service layer, client implementation, and a new CI pipeline. It allows the application to validate user input and send a POST request to the JSONPlaceholder API to create a new resource.
Changes Included
Service Layer (PostServiceImpl)
createPostmethod.Client Layer (JsonPlaceholderClient)
createPostmethod to perform a live HTTP POST request.Content-Typeheader.Continuous Integration (ci.yml)
mainbranch, ensuring that all tests must pass before a merge can occur.