Avoid using aspect-ratio CSS property - #1258
Merged
Merged
Conversation
Not supported in Safari 14. Switch to the AspectRatio component, which uses percentage-based padding, and introduce a class that mimics this approach for ratios only known at runtime.
|
Preview build will be at |
Collaborator
|
This looks fine but holding off on merging to ponder whether there should be any library support for the dynamic aspect ratio thing. |
Collaborator
Author
There is a similar kind of override for the recording graph preview in the settings dialog for ml-trainer, but nothing else in the family needs it. |
microbit-matt-hillsdon
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not supported in Safari 14. Switch to the AspectRatio component, which
uses percentage-based padding, and introduce a class that mimics this
approach for ratios only known at runtime.
See microbit-foundation/ui#72