Skip to content

fetch: Return early on error#280

Merged
gRegorLove merged 1 commit into
microformats:mainfrom
jtojnar:fetch-err
Jun 25, 2026
Merged

fetch: Return early on error#280
gRegorLove merged 1 commit into
microformats:mainfrom
jtojnar:fetch-err

Conversation

@jtojnar

@jtojnar jtojnar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

If an curl fails, we would get the following warning:

Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated

If an curl fails, we would get the following warning:

    Deprecated: strtolower(): Passing null to parameter microformats#1 ($string) of type string is deprecated

@gRegorLove gRegorLove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gRegorLove gRegorLove added this to the 0.5.1 milestone Jun 25, 2026
@gRegorLove gRegorLove merged commit d98af38 into microformats:main Jun 25, 2026
17 of 18 checks passed
@jtojnar jtojnar deleted the fetch-err branch June 25, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants