Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new Google ADK (Agent Development Kit) tooling extension to the Agent365 Python SDK. The extension provides MCP (Model Context Protocol) tool registration capabilities for Google ADK-based agents, allowing them to dynamically discover and integrate MCP tool servers.
Changes:
- Added new
microsoft-agents-a365-tooling-extensions-googlelibrary package with MCP tool registration service - Implemented comprehensive unit tests covering initialization, tool server registration, error handling, and cleanup
- Updated workspace configuration to include the new Google extension package
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/services/mcp_tool_registration_service.py |
Core service implementation for registering MCP tool servers with Google ADK agents |
libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/services/__init__.py |
Service module exports |
libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/__init__.py |
Package initialization and public API exports |
libraries/microsoft-agents-a365-tooling-extensions-google/setup.py |
Package build configuration with dynamic versioning |
libraries/microsoft-agents-a365-tooling-extensions-google/pyproject.toml |
Package metadata, dependencies, and tool configurations |
libraries/microsoft-agents-a365-tooling-extensions-google/README.md |
Package overview and documentation links |
libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md |
Architectural documentation and usage examples |
tests/tooling/extensions/google/test_mcp_tool_registration_service.py |
Comprehensive unit tests for the registration service |
tests/tooling/extensions/google/__init__.py |
Test package initialization |
pyproject.toml |
Added Google extension to workspace members and dependency constraints |
tests/RUNNING_TESTS.md |
Updated test installation instructions to include Google extension |
libraries/LICENSE.md |
MIT license file for the libraries directory |
libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md
Outdated
Show resolved
Hide resolved
libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md
Outdated
Show resolved
Hide resolved
libraries/microsoft-agents-a365-tooling-extensions-googleadk/pyproject.toml
Show resolved
Hide resolved
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@JesuTerraz I've opened a new pull request, #157, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix design.md and add ruff copyright config per review comments Co-authored-by: JesuTerraz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JesuTerraz <[email protected]>
libraries/microsoft-agents-a365-tooling-extensions-google/setup.py
Outdated
Show resolved
Hide resolved
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@JesuTerraz I've opened a new pull request, #158, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix setup.py consistency and add @pytest.mark.unit decorators Co-authored-by: JesuTerraz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JesuTerraz <[email protected]>
...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py
Show resolved
Hide resolved
...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py
Outdated
Show resolved
Hide resolved
|
@JesuTerraz I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you. |
libraries/microsoft-agents-a365-tooling-extensions-googleadk/pyproject.toml
Show resolved
Hide resolved
…sion (#168) * Initial plan * Add de-duplication logic to prevent duplicate MCP server registration Co-authored-by: JesuTerraz <[email protected]> * Optimize duplicate detection with set for O(1) lookup performance Co-authored-by: JesuTerraz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JesuTerraz <[email protected]>
tests/tooling/extensions/googleadk/test_mcp_tool_registration_service.py
Outdated
Show resolved
Hide resolved
...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…om/microsoft/Agent365-python into users/jterrazas/google-adk-support
tests/tooling/extensions/googleadk/test_mcp_tool_registration_service.py
Outdated
Show resolved
Hide resolved
tests/tooling/extensions/googleadk/test_mcp_tool_registration_service.py
Show resolved
Hide resolved
|
@copilot open a new pull request to apply changes based on the unresolved comments in this thread |
|
@JesuTerraz I've opened a new pull request, #169, to work on those changes. Once the pull request is ready, I'll request review from you. |
…#169) * Initial plan * Remove unnecessary Agent patches from googleadk tests Co-authored-by: JesuTerraz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JesuTerraz <[email protected]>
No description provided.