Skip to content

Fix shell injection vulnerability in /resolve-review command #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pontemonti merged 2 commits into from
Feb 6, 2026
Merged

Fix shell injection vulnerability in /resolve-review command #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c338afd
Initial plan
Copilot Feb 6, 2026
8a4afbd
Add shell injection protection for branch names in resolve-review com…
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .claude/commands/resolve-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,27 @@ For each issue marked "Agent Resolvable: Yes":
1. Push the fix branch to origin:
```bash
cd .worktrees/pr-<PR_NUMBER>-fixes
git push -u origin <FIX_BRANCH_NAME>
git push -u origin "$FIX_BRANCH_NAME"
```

2. Create a PR to merge fixes into the original PR branch:
```bash
gh pr create --base <ORIGINAL_PR_HEAD_BRANCH> --head <FIX_BRANCH_NAME> --title "fix: address code review comments for PR #<PR_NUMBER>" --body "$(cat <<'EOF'
# Validate that branch names are safe (alphanumerics, dot, slash, dash, underscore)
case "$ORIGINAL_PR_HEAD_BRANCH" in
(*[!A-Za-z0-9._/-]*|'')
echo "Error: ORIGINAL_PR_HEAD_BRANCH contains unsafe characters: $ORIGINAL_PR_HEAD_BRANCH" >&2
exit 1
;;
esac

case "$FIX_BRANCH_NAME" in
(*[!A-Za-z0-9._/-]*|'')
echo "Error: FIX_BRANCH_NAME contains unsafe characters: $FIX_BRANCH_NAME" >&2
exit 1
;;
esac

gh pr create --base "$ORIGINAL_PR_HEAD_BRANCH" --head "$FIX_BRANCH_NAME" --title "fix: address code review comments for PR #<PR_NUMBER>" --body "$(cat <<'EOF'
## Summary
Addresses agent-resolvable code review comments from PR #<PR_NUMBER>.

Expand Down