Fix early exit of /log/public/historical/range when there are empty pages#7869
Open
cjen1-msft wants to merge 6 commits intomicrosoft:mainfrom
Open
Fix early exit of /log/public/historical/range when there are empty pages#7869cjen1-msft wants to merge 6 commits intomicrosoft:mainfrom
cjen1-msft wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the logging sample app’s historical range pagination so clients continue iterating across empty pages, rather than terminating early when a non-first page contains no entries.
Changes:
- Always emit
@nextLink(viaresponse.next_link) when the requested historical range isn’t fully covered yet, even if the next page is empty. - Keep prefetch behaviour only when the next page is known (via the index) to contain interesting seqnos.
- Add a changelog note describing the fix.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md.github/instructions/changelog.instructions.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
samples/apps/logging/logging.cpp |
Removes early-exit pagination optimisation by always returning a next_link when more of the requested seqno range remains. |
CHANGELOG.md |
Adds a “Fixed” entry describing the logging app pagination fix. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Contributor
Author
|
Waiting for the mypy fix in #7867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we reduced the logging page size in a recent test we had a failure where the range query did not turn up the entry.
This is because if there is is an empty page (not the first page), then the range query would exit early rather than directing the client to continue iterating past it.
One possible optimisation here is that the @nextlink could skip across that empty page, but this version is obviously correct, if slightly inefficient.
This was tested using a reduced page size of 10, and submitting 10 txs and their signatures. with an 11th tx which we then queried for.