[SM6.10] Add built-in type for LinAlg Matrix handle#8090
[SM6.10] Add built-in type for LinAlg Matrix handle#8090hekota merged 10 commits intomicrosoft:mainfrom
Conversation
Adds a built-in type `__builtin_LinAlg_Matrix` that will be used in LinAlg Matrix implementation.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
damyanp
left a comment
There was a problem hiding this comment.
LGTM, but you probably want an approval from someone more knowledgeable.
|
About to start a deeper review but wanted to get this out there as quickly as possible. How do you feel about Looking back on chat history it looks like I +1'd My thoughts on why are below:
If you are okay with the change I'm more than happy to do the chore work of renaming everything |
| case BuiltinType::OCLSampler: ID = PREDEF_TYPE_SAMPLER_ID; break; | ||
| case BuiltinType::OCLEvent: ID = PREDEF_TYPE_EVENT_ID; break; | ||
| case BuiltinType::LinAlgMatrix: | ||
| ID = PREDEF_TYPE_LINALG_MATRIX_ID; |
There was a problem hiding this comment.
Fine, but we never supported AST serialization in this code base, and there are many missing pieces already. That's why we never added the other HLSL types here.
V-FEXrt
left a comment
There was a problem hiding this comment.
LGTM*, like Damyan I'm going to leave someone else to approve since this shape of adding a type is very new looking to me :)
*of course I'd like to discuss the time name as mentioned above
I agree, |
llvm-beanz
left a comment
There was a problem hiding this comment.
As @tex3d pointed out the AST bitcode serialization is effectively untestable because it's all totally broken, but the change looks good and reasonable to me.
Adds a built-in type
__builtin_LinAlgMatrixthat will be used in LinAlg Matrix implementation for SM 6.10.Closes #8121