Skip to content

[NFC] Fix TAEF string literals in HLSL exec tests #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deric C. (Icohedron) merged 2 commits into from
Oct 6, 2026
Merged

[NFC] Fix TAEF string literals in HLSL exec tests #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3936846
Fix TAEF string literals in HLSL exec tests
Icohedron Oct 5, 2026
50fecf8
Apply clang-format
Icohedron Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,11 +1579,11 @@ void addHeapRawUAV(st::ShaderOp *Op, const char *HeapName, const char *ResName,
// A raw view counts 32-bit words, so a byte size that is not a whole number
// of words cannot be represented and would silently round down.
VERIFY_IS_TRUE(ViewBytes % 4 == 0,
"raw UAV view size must be a multiple of 4 bytes");
L"raw UAV view size must be a multiple of 4 bytes");
// NumElements is 32 bits, so a larger view cannot be described at all and
// narrowing would silently bind a shorter one.
VERIFY_IS_TRUE(ViewBytes / 4 <= UINT_MAX,
"raw UAV view size exceeds what NumElements can describe");
L"raw UAV view size exceeds what NumElements can describe");

st::ShaderOpDescriptor D = {};
D.Name = Op->Strings.insert(ResName);
Expand Down Expand Up @@ -1703,8 +1703,9 @@ UINT getLinAlgMatrixByteSize(ID3D12Device *Device, UINT NumRows,
Info.DestDataType = DataType;
LinAlgDevice->GetLinearAlgebraMatrixConversionDestinationInfo(&Info);
VERIFY_IS_TRUE(Info.DestSize != 0,
"Device reported no destination size for the requested "
"linear algebra matrix layout");
L"Device reported no destination size for the requested "
L"linear algebra matrix layout");

return Info.DestSize;
}

Expand Down
Loading
Loading