Skip to content

Add DXC root-cause investigation guidance - #9009

Merged
Damyan Pepper (damyanp) merged 3 commits into
mainfrom
damyanp-compile-time-investigation-guidance
Oct 7, 2026
Merged

Damyan Pepper (damyanp) merged 3 commits into
mainfrom
damyanp-compile-time-investigation-guidance

Conversation

@damyanp

@damyanp Damyan Pepper (damyanp) commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Add a root AGENTS.md with concise guidance for investigating DXC compile-time regressions and miscompiles.

This is contributor and agent guidance only, with no user-visible compiler behavior change, so it does not require a release note under CONTRIBUTING.md.

Assisted by GitHub Copilot.

Capture the investigation habits that avoid local DXC regressions and misleading upstream comparisons.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 17:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation-only change is narrowly scoped, with no unresolved findings or blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a selectively loaded DXC investigation skill to guide root-cause analysis without expanding repository-wide instructions.

Changes:

  • Adds guidance on local fork history, shared tuning constants, and reproducer validation.
  • Documents a memory-dependence regression example and test-coverage limitations.
  • Clarifies why this documentation-only change needs no release note.
File Description
.github/​skills/​root-cause-investigation/​SKILL.md Defines the investigation skill, checklist, and worked example.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Make the root-cause checklist repository-wide instead of requiring explicit skill invocation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 17:53
@damyanp Damyan Pepper (damyanp) changed the title Add root-cause investigation skill Add DXC root-cause investigation guidance Oct 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation is consistent with the supplied repository context and linked changes, with no unresolved issues.

Review effort: Balanced
Findings: None

@llvm-beanz Chris B (llvm-beanz) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but otherwise this looks good.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Make HLSL Change markers explicitly non-exhaustive and document how to reconstruct local and upstream baselines.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

This documentation-only change has no identified blocking issues and does not require a release note.

Review effort: Balanced
Findings: None

@joaosaffran joaosaffran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I personally would like to see some output examples produced by an agent following this rules, it would simplify evaluating if those make sense or not. Not sure if this is possible though

Comment thread AGENTS.md

### Example

`MemoryDependenceAnalysis` used a file-scope `BlockScanLimit` of 500 after

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this example produced by an agent following this rules? It would be nice to see some examples somewhere of how those rules are being applied, but maybe this is not possible... yet

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example came about to try and improve the bad job an agent originally did trying to address this problem.

@damyanp
Damyan Pepper (damyanp) merged commit 75fba61 into main Oct 7, 2026
13 checks passed
@damyanp
Damyan Pepper (damyanp) deleted the damyanp-compile-time-investigation-guidance branch October 7, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants