Repository navigation
Add DXC root-cause investigation guidance - #9009
Conversation
Capture the investigation habits that avoid local DXC regressions and misleading upstream comparisons. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation-only change is narrowly scoped, with no unresolved findings or blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a selectively loaded DXC investigation skill to guide root-cause analysis without expanding repository-wide instructions.
Changes:
- Adds guidance on local fork history, shared tuning constants, and reproducer validation.
- Documents a memory-dependence regression example and test-coverage limitations.
- Clarifies why this documentation-only change needs no release note.
| File | Description |
|---|---|
.github/skills/root-cause-investigation/SKILL.md |
Defines the investigation skill, checklist, and worked example. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Make the root-cause checklist repository-wide instead of requiring explicit skill invocation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Chris B (llvm-beanz)
left a comment
There was a problem hiding this comment.
A few comments, but otherwise this looks good.
Make HLSL Change markers explicitly non-exhaustive and document how to reconstruct local and upstream baselines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
joaosaffran
left a comment
There was a problem hiding this comment.
LGTM, I personally would like to see some output examples produced by an agent following this rules, it would simplify evaluating if those make sense or not. Not sure if this is possible though
|
|
||
| ### Example | ||
|
|
||
| `MemoryDependenceAnalysis` used a file-scope `BlockScanLimit` of 500 after |
There was a problem hiding this comment.
Was this example produced by an agent following this rules? It would be nice to see some examples somewhere of how those rules are being applied, but maybe this is not possible... yet
There was a problem hiding this comment.
This example came about to try and improve the bad job an agent originally did trying to address this problem.
Add a root
AGENTS.mdwith concise guidance for investigating DXC compile-time regressions and miscompiles.This is contributor and agent guidance only, with no user-visible compiler behavior change, so it does not require a release note under
CONTRIBUTING.md.Assisted by GitHub Copilot.