Remove AlignedBoxWithSlice in favor of Poly<[T], AlignedAllocator> directly#908
Draft
Remove AlignedBoxWithSlice in favor of Poly<[T], AlignedAllocator> directly#908
AlignedBoxWithSlice in favor of Poly<[T], AlignedAllocator> directly#908Conversation
…aligned_alloc constructor - Replace AlignedBoxWithSlice<T> struct with type alias AlignedSlice<T> = Poly<[T], AlignedAllocator> - Add aligned_alloc<T>() constructor function - Replace split_into_nonoverlapping_mut_slices() with standard chunks_mut() - Replace memcpy() with standard copy_from_slice() - Replace as_slice()/as_mut_slice() with direct Deref/DerefMut access - Update all usages in diskann-providers, diskann-disk, and diskann-tools Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/03833fc4-6079-4233-b63d-96e1a0eb246d Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove AlignedBoxWithSlice and replace with Poly
Remove Apr 6, 2026
AlignedBoxWithSlice in favor of Poly<[T], AlignedAllocator> directly
…ntization::alloc - Add `AlignedSlice<T>` type alias and `aligned_slice()` convenience function to `diskann-quantization::alloc` with `AllocatorError` return type (no ANNError coupling) - Add tests for the new function in diskann-quantization - Update diskann-disk source, tests, and benchmarks to import from diskann_quantization::alloc - Update diskann-tools to import from diskann_quantization::alloc - Update diskann-providers bench files to import from diskann_quantization::alloc - Keep backward-compatible re-exports in diskann-providers::common - Delete diskann-providers/src/common/aligned_allocator.rs Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/602b854a-223a-423c-a053-70c24744a4a5 Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
…h.rs error handling Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/602b854a-223a-423c-a053-70c24744a4a5 Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aligned_allocandAlignedSliceusageAlignedSlice<T>type alias andaligned_sliceconvenience function todiskann-quantization::allocdiskann-quantizationdiskann-providersto re-export fromdiskann-quantization(backward compat) and updatecommon/mod.rsdiskann-diskcallers to import fromdiskann_quantization::allocdiskann-toolscallers to import fromdiskann_quantization::allocdiskann-diskanddiskann-providersbench filesdiskann-providers/src/common/aligned_allocator.rs