test(client-fluid-telemetry): support build-and-test:unit:*#27003
Open
jason-ha wants to merge 2 commits intomicrosoft:mainfrom
Open
test(client-fluid-telemetry): support build-and-test:unit:*#27003jason-ha wants to merge 2 commits intomicrosoft:mainfrom
jason-ha wants to merge 2 commits intomicrosoft:mainfrom
Conversation
fluid-telemetry has specialized unit tests with no entry that allows `build-and-test:unit:esm` to build or test. 1. Add `test:mocha:esm` pointing to `test:mocha:esm:unit`. 2. Update task deps such that any of the mocha tests can be fluid-build tasks (get automatic build before run).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates @fluidframework/fluid-telemetry’s test script surface so the repo-level build-and-test:unit:* / test:unit:* fluid-build tasks can correctly build and execute the package’s Mocha unit tests (especially for ESM), and so the package’s more specific Mocha scripts can be run as fluid-build tasks with appropriate build prerequisites.
Changes:
- Add
test:mocha:esmandtest:mocha:cjsscripts as unit-test aliases to match the repo’s fluid-build task expectations. - Add
fluidBuild.tasksentries sotest:mocha:*:{unit,all,end-to-end}tasks automatically depend on the appropriatebuild:test:*tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fluid-telemetry has specialized unit tests with no entry that allows
build-and-test:unit:esmto build or test.test:mocha:esmpointing totest:mocha:esm:unit.