refactor: change default audio paths in samples#594
Open
Kazunari001 wants to merge 3 commits intomicrosoft:mainfrom
Open
refactor: change default audio paths in samples#594Kazunari001 wants to merge 3 commits intomicrosoft:mainfrom
Kazunari001 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the audio transcription samples to use a shared default audio file under samples/assets/audio/Recording.mp3 rather than per-sample local copies.
Changes:
- Rust sample: default audio path now resolves from
CARGO_MANIFEST_DIRintosamples/assets/audio/Recording.mp3. - Python sample: default audio path now resolves relative to the script file into
samples/assets/audio/Recording.mp3. - JS sample and C# project: default/reference updated to
../../assets/audio/Recording.mp3(with C# copying the shared file to output).
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| samples/rust/audio-transcription-example/src/main.rs | Switch default audio file to shared samples/assets/audio/Recording.mp3 using CARGO_MANIFEST_DIR. |
| samples/python/audio-transcription/src/app.py | Switch default audio file to shared samples/assets/audio/Recording.mp3 using __file__-relative pathing. |
| samples/js/audio-transcription-example/app.js | Switch default audio file path to shared ../../assets/audio/Recording.mp3. |
| samples/cs/audio-transcription-example/AudioTranscriptionExample.csproj | Copy shared Recording.mp3 from samples/assets/audio into build output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…le.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.