Skip to content

feat(schema): resolve bare $dynamicRef via $dynamicAnchor index #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aqeelat wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(schema): resolve bare $dynamicRef via $dynamicAnchor index #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4922341
feat(schema): resolve $dynamicRef against $dynamicAnchor via OpenApiS…
aqeelat Jun 29, 2026
00c6a27
fix(tests): use ReferenceHandler.Preserve for STJ snapshot with $dyna…
aqeelat Jul 5, 2026
204c63b
fix: address review feedback for $dynamicRef PR
aqeelat Jul 6, 2026
7ebc8b5
fix: use FirstOrDefault instead of foreach+if in FindDocumentByBaseUri
aqeelat Jul 7, 2026
66f8f60
chore(benchmark): update performance reports
aqeelat Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...ark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
AMD EPYC 9V74 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
Expand All @@ -12,9 +12,9 @@ WarmupCount=3
```
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
|------------- |---------------:|--------------:|-------------:|-----------:|-----------:|----------:|-------------:|
| PetStoreYaml | 491.4 μs | 72.31 μs | 3.96 μs | 18.5547 | 3.9063 | - | 314.57 KB |
| PetStoreJson | 199.4 μs | 19.87 μs | 1.09 μs | 10.7422 | 2.9297 | - | 176.42 KB |
| GHESYaml | 939,520.0 μs | 187,454.80 μs | 10,275.03 μs | 18000.0000 | 17000.0000 | 3000.0000 | 256688.91 KB |
| GHESJson | 282,084.8 μs | 100,501.66 μs | 5,508.84 μs | 6000.0000 | 5000.0000 | 1000.0000 | 113857.84 KB |
| GHESNextYaml | 1,152,354.7 μs | 45,814.56 μs | 2,511.25 μs | 30000.0000 | 18000.0000 | 3000.0000 | 452765.4 KB |
| GHESNextJson | 549,904.6 μs | 80,767.59 μs | 4,427.14 μs | 20000.0000 | 10000.0000 | 2000.0000 | 314529.52 KB |
| PetStoreYaml | 461.5 μs | 100.42 μs | 5.50 μs | 19.5313 | 3.9063 | - | 323.19 KB |
| PetStoreJson | 181.3 μs | 16.34 μs | 0.90 μs | 10.7422 | 1.9531 | - | 185.05 KB |
| GHESYaml | 1,028,913.1 μs | 217,737.98 μs | 11,934.95 μs | 19000.0000 | 18000.0000 | 3000.0000 | 261642.32 KB |
| GHESJson | 356,086.1 μs | 128,283.32 μs | 7,031.64 μs | 8000.0000 | 7000.0000 | 2000.0000 | 118811.6 KB |
| GHESNextYaml | 1,203,933.7 μs | 84,492.60 μs | 4,631.32 μs | 31000.0000 | 19000.0000 | 3000.0000 | 458486.92 KB |
| GHESNextJson | 547,853.5 μs | 83,500.33 μs | 4,576.93 μs | 20000.0000 | 10000.0000 | 2000.0000 | 320247.3 KB |
12 changes: 6 additions & 6 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Method,Job,AnalyzeLaunchVariance,EvaluateOverhead,MaxAbsoluteError,MaxRelativeError,MinInvokeCount,MinIterationTime,OutlierMode,Affinity,EnvironmentVariables,Jit,LargeAddressAware,Platform,PowerPlanMode,Runtime,AllowVeryLargeObjects,Concurrent,CpuGroups,Force,HeapAffinitizeMask,HeapCount,NoAffinitize,RetainVm,Server,Arguments,BuildConfiguration,Clock,EngineFactory,NuGetReferences,Toolchain,IsMutator,InvocationCount,IterationCount,IterationTime,LaunchCount,MaxIterationCount,MaxWarmupIterationCount,MemoryRandomization,MinIterationCount,MinWarmupIterationCount,RunStrategy,UnrollFactor,WarmupCount,Mean,Error,StdDev,Gen0,Gen1,Gen2,Allocated
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,491.4 μs,72.31 μs,3.96 μs,18.5547,3.9063,0.0000,314.57 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,199.4 μs,19.87 μs,1.09 μs,10.7422,2.9297,0.0000,176.42 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"939,520.0 μs","187,454.80 μs","10,275.03 μs",18000.0000,17000.0000,3000.0000,256688.91 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"282,084.8 μs","100,501.66 μs","5,508.84 μs",6000.0000,5000.0000,1000.0000,113857.84 KB
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,152,354.7 μs","45,814.56 μs","2,511.25 μs",30000.0000,18000.0000,3000.0000,452765.4 KB
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"549,904.6 μs","80,767.59 μs","4,427.14 μs",20000.0000,10000.0000,2000.0000,314529.52 KB
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,461.5 μs,100.42 μs,5.50 μs,19.5313,3.9063,0.0000,323.19 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,181.3 μs,16.34 μs,0.90 μs,10.7422,1.9531,0.0000,185.05 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,028,913.1 μs","217,737.98 μs","11,934.95 μs",19000.0000,18000.0000,3000.0000,261642.32 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"356,086.1 μs","128,283.32 μs","7,031.64 μs",8000.0000,7000.0000,2000.0000,118811.6 KB
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,203,933.7 μs","84,492.60 μs","4,631.32 μs",31000.0000,19000.0000,3000.0000,458486.92 KB
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"547,853.5 μs","83,500.33 μs","4,576.93 μs",20000.0000,10000.0000,2000.0000,320247.3 KB
16 changes: 8 additions & 8 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang='en'>
<head>
<meta charset='utf-8' />
<title>performance.Descriptions-20260629-200911</title>
<title>performance.Descriptions-20260707-174448</title>

<style type="text/css">
table { border-collapse: collapse; display: block; width: 100%; overflow: auto; }
Expand All @@ -14,7 +14,7 @@
<body>
<pre><code>
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
AMD EPYC 9V74 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
Expand All @@ -26,12 +26,12 @@
<table>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
</tr>
</thead><tbody><tr><td>PetStoreYaml</td><td>491.4 &mu;s</td><td>72.31 &mu;s</td><td>3.96 &mu;s</td><td>18.5547</td><td>3.9063</td><td>-</td><td>314.57 KB</td>
</tr><tr><td>PetStoreJson</td><td>199.4 &mu;s</td><td>19.87 &mu;s</td><td>1.09 &mu;s</td><td>10.7422</td><td>2.9297</td><td>-</td><td>176.42 KB</td>
</tr><tr><td>GHESYaml</td><td>939,520.0 &mu;s</td><td>187,454.80 &mu;s</td><td>10,275.03 &mu;s</td><td>18000.0000</td><td>17000.0000</td><td>3000.0000</td><td>256688.91 KB</td>
</tr><tr><td>GHESJson</td><td>282,084.8 &mu;s</td><td>100,501.66 &mu;s</td><td>5,508.84 &mu;s</td><td>6000.0000</td><td>5000.0000</td><td>1000.0000</td><td>113857.84 KB</td>
</tr><tr><td>GHESNextYaml</td><td>1,152,354.7 &mu;s</td><td>45,814.56 &mu;s</td><td>2,511.25 &mu;s</td><td>30000.0000</td><td>18000.0000</td><td>3000.0000</td><td>452765.4 KB</td>
</tr><tr><td>GHESNextJson</td><td>549,904.6 &mu;s</td><td>80,767.59 &mu;s</td><td>4,427.14 &mu;s</td><td>20000.0000</td><td>10000.0000</td><td>2000.0000</td><td>314529.52 KB</td>
</thead><tbody><tr><td>PetStoreYaml</td><td>461.5 &mu;s</td><td>100.42 &mu;s</td><td>5.50 &mu;s</td><td>19.5313</td><td>3.9063</td><td>-</td><td>323.19 KB</td>
</tr><tr><td>PetStoreJson</td><td>181.3 &mu;s</td><td>16.34 &mu;s</td><td>0.90 &mu;s</td><td>10.7422</td><td>1.9531</td><td>-</td><td>185.05 KB</td>
</tr><tr><td>GHESYaml</td><td>1,028,913.1 &mu;s</td><td>217,737.98 &mu;s</td><td>11,934.95 &mu;s</td><td>19000.0000</td><td>18000.0000</td><td>3000.0000</td><td>261642.32 KB</td>
</tr><tr><td>GHESJson</td><td>356,086.1 &mu;s</td><td>128,283.32 &mu;s</td><td>7,031.64 &mu;s</td><td>8000.0000</td><td>7000.0000</td><td>2000.0000</td><td>118811.6 KB</td>
</tr><tr><td>GHESNextYaml</td><td>1,203,933.7 &mu;s</td><td>84,492.60 &mu;s</td><td>4,631.32 &mu;s</td><td>31000.0000</td><td>19000.0000</td><td>3000.0000</td><td>458486.92 KB</td>
</tr><tr><td>GHESNextJson</td><td>547,853.5 &mu;s</td><td>83,500.33 &mu;s</td><td>4,576.93 &mu;s</td><td>20000.0000</td><td>10000.0000</td><td>2000.0000</td><td>320247.3 KB</td>
</tr></tbody></table>
</body>
</html>
2 changes: 1 addition & 1 deletion performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json
View file
Open in desktop

Large diffs are not rendered by default.

62 changes: 31 additions & 31 deletions ...mark/BenchmarkDotNet.Artifacts/results/performance.EmptyModels-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
AMD EPYC 9V74 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
Expand All @@ -10,33 +10,33 @@ Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3

```
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|---------------------------- |-------------:|----------:|----------:|-------:|----------:|
| EmptyApiCallback | 14.077 ns | 5.879 ns | 0.3223 ns | 0.0019 | 32 B |
| EmptyApiComponents | 14.353 ns | 27.787 ns | 1.5231 ns | 0.0067 | 112 B |
| EmptyApiContact | 8.820 ns | 4.774 ns | 0.2617 ns | 0.0029 | 48 B |
| EmptyApiDiscriminator | 12.366 ns | 17.252 ns | 0.9456 ns | 0.0029 | 48 B |
| EmptyDocument | 1,227.975 ns | 78.094 ns | 4.2806 ns | 0.0668 | 1144 B |
| EmptyApiEncoding | 16.017 ns | 39.797 ns | 2.1814 ns | 0.0048 | 80 B |
| EmptyApiExample | 13.024 ns | 4.635 ns | 0.2541 ns | 0.0043 | 72 B |
| EmptyApiExternalDocs | 14.738 ns | 18.712 ns | 1.0257 ns | 0.0024 | 40 B |
| EmptyApiHeader | 13.615 ns | 12.637 ns | 0.6927 ns | 0.0048 | 80 B |
| EmptyApiInfo | 13.339 ns | 36.579 ns | 2.0050 ns | 0.0048 | 80 B |
| EmptyApiLicense | 11.728 ns | 27.400 ns | 1.5019 ns | 0.0029 | 48 B |
| EmptyApiLink | 14.362 ns | 51.417 ns | 2.8183 ns | 0.0043 | 72 B |
| EmptyApiMediaType | 11.310 ns | 2.030 ns | 0.1113 ns | 0.0048 | 80 B |
| EmptyApiOAuthFlow | 8.204 ns | 2.441 ns | 0.1338 ns | 0.0038 | 64 B |
| EmptyApiOAuthFlows | 11.544 ns | 20.185 ns | 1.1064 ns | 0.0038 | 64 B |
| EmptyApiOperation | 76.914 ns | 36.381 ns | 1.9942 ns | 0.0224 | 376 B |
| EmptyApiParameter | 12.591 ns | 24.321 ns | 1.3331 ns | 0.0057 | 96 B |
| EmptyApiPathItem | 15.782 ns | 25.659 ns | 1.4064 ns | 0.0038 | 64 B |
| EmptyApiPaths | 60.798 ns | 12.323 ns | 0.6755 ns | 0.0148 | 248 B |
| EmptyApiRequestBody | 9.189 ns | 14.175 ns | 0.7770 ns | 0.0029 | 48 B |
| EmptyApiResponse | 14.850 ns | 20.664 ns | 1.1327 ns | 0.0038 | 64 B |
| EmptyApiResponses | 64.813 ns | 29.839 ns | 1.6356 ns | 0.0148 | 248 B |
| EmptyApiSchema | 22.176 ns | 8.769 ns | 0.4807 ns | 0.0306 | 512 B |
| EmptyApiSecurityRequirement | 16.838 ns | 11.238 ns | 0.6160 ns | 0.0062 | 104 B |
| EmptyApiSecurityScheme | 11.860 ns | 15.234 ns | 0.8350 ns | 0.0062 | 104 B |
| EmptyApiServer | 7.778 ns | 3.765 ns | 0.2063 ns | 0.0033 | 56 B |
| EmptyApiServerVariable | 13.466 ns | 11.117 ns | 0.6093 ns | 0.0029 | 48 B |
| EmptyApiTag | 8.794 ns | 5.167 ns | 0.2832 ns | 0.0043 | 72 B |
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|---------------------------- |-------------:|-----------:|----------:|-------:|----------:|
| EmptyApiCallback | 7.232 ns | 8.3210 ns | 0.4561 ns | 0.0019 | 32 B |
| EmptyApiComponents | 8.984 ns | 3.9685 ns | 0.2175 ns | 0.0067 | 112 B |
| EmptyApiContact | 6.717 ns | 0.2355 ns | 0.0129 ns | 0.0029 | 48 B |
| EmptyApiDiscriminator | 6.867 ns | 0.5429 ns | 0.0298 ns | 0.0029 | 48 B |
| EmptyDocument | 1,355.077 ns | 48.3170 ns | 2.6484 ns | 0.0687 | 1160 B |
| EmptyApiEncoding | 8.288 ns | 1.3399 ns | 0.0734 ns | 0.0048 | 80 B |
| EmptyApiExample | 7.900 ns | 2.2296 ns | 0.1222 ns | 0.0043 | 72 B |
| EmptyApiExternalDocs | 6.854 ns | 3.4840 ns | 0.1910 ns | 0.0024 | 40 B |
| EmptyApiHeader | 7.539 ns | 1.8631 ns | 0.1021 ns | 0.0048 | 80 B |
| EmptyApiInfo | 7.943 ns | 1.2944 ns | 0.0710 ns | 0.0048 | 80 B |
| EmptyApiLicense | 6.433 ns | 2.5159 ns | 0.1379 ns | 0.0029 | 48 B |
| EmptyApiLink | 8.250 ns | 4.0745 ns | 0.2233 ns | 0.0043 | 72 B |
| EmptyApiMediaType | 8.189 ns | 7.1944 ns | 0.3943 ns | 0.0048 | 80 B |
| EmptyApiOAuthFlow | 8.402 ns | 3.6129 ns | 0.1980 ns | 0.0038 | 64 B |
| EmptyApiOAuthFlows | 7.220 ns | 2.3217 ns | 0.1273 ns | 0.0038 | 64 B |
| EmptyApiOperation | 78.147 ns | 25.1014 ns | 1.3759 ns | 0.0224 | 376 B |
| EmptyApiParameter | 7.926 ns | 17.9080 ns | 0.9816 ns | 0.0057 | 96 B |
| EmptyApiPathItem | 7.019 ns | 3.9054 ns | 0.2141 ns | 0.0038 | 64 B |
| EmptyApiPaths | 61.040 ns | 4.2915 ns | 0.2352 ns | 0.0148 | 248 B |
| EmptyApiRequestBody | 8.099 ns | 2.2266 ns | 0.1220 ns | 0.0029 | 48 B |
| EmptyApiResponse | 7.329 ns | 1.7690 ns | 0.0970 ns | 0.0038 | 64 B |
| EmptyApiResponses | 64.278 ns | 10.6687 ns | 0.5848 ns | 0.0148 | 248 B |
| EmptyApiSchema | 18.917 ns | 0.8634 ns | 0.0473 ns | 0.0306 | 512 B |
| EmptyApiSecurityRequirement | 15.816 ns | 7.6579 ns | 0.4198 ns | 0.0062 | 104 B |
| EmptyApiSecurityScheme | 8.543 ns | 0.9986 ns | 0.0547 ns | 0.0062 | 104 B |
| EmptyApiServer | 7.023 ns | 10.9048 ns | 0.5977 ns | 0.0033 | 56 B |
| EmptyApiServerVariable | 6.945 ns | 0.4329 ns | 0.0237 ns | 0.0029 | 48 B |
| EmptyApiTag | 7.579 ns | 1.4125 ns | 0.0774 ns | 0.0043 | 72 B |
Loading
Loading