Skip to content

Add simulation-validation protocol and validate-simulation template#100

Merged
Alan-Jowett merged 4 commits intomicrosoft:mainfrom
Alan-Jowett:add-simulation-validation
Mar 29, 2026
Merged

Add simulation-validation protocol and validate-simulation template#100
Alan-Jowett merged 4 commits intomicrosoft:mainfrom
Alan-Jowett:add-simulation-validation

Conversation

@Alan-Jowett
Copy link
Copy Markdown
Member

Summary

Phase 2 of #91 — adds circuit simulation review capability. Reviews SPICE output, power budget calculations, and thermal analysis against specification constraints.

New Components

Type Name Path Description
Protocol simulation-validation protocols/analysis/simulation-validation.md 6-phase simulation review methodology
Template validate-simulation templates/validate-simulation.md Review simulation output against spec constraints

Protocol Phases

  1. Simulation setup review (stimuli, models, measurement points)
  2. Result extraction (steady-state, transient, ripple, worst-case)
  3. Constraint compliance check (map results to spec constraints)
  4. Corner-case assessment (voltage/load/temperature corners)
  5. Model validity assessment (manufacturer vs generic, parasitics)
  6. Findings summary with simulation coverage report

Design Decisions

Checklist

  • All files have SPDX license headers
  • YAML frontmatter is valid and complete
  • Component names match file names (kebab-case)
  • manifest.yaml updated with all new components
  • No vague instructions in protocols or templates
  • Protocols have numbered, ordered phases
  • Templates have a quality checklist section
  • New components do not conflict with existing ones
  • python tests/validate-manifest.py passes

Phase 2 of microsoft#91 — adds circuit simulation review capability.

- Protocol: simulation-validation (analysis) — 6-phase methodology
  covering setup verification (stimuli, models, measurement points),
  result extraction, constraint compliance checking, corner-case
  assessment (voltage/load/temperature corners), model validity
  evaluation (manufacturer vs generic, parasitic completeness), and
  simulation coverage summary.

- Template: validate-simulation — uses electrical-engineer persona +
  protocol + investigation-report format. Reviews SPICE output, power
  budgets, and thermal analysis against specification constraints.

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings March 29, 2026 04:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds PromptKit support for validating circuit simulation artifacts by introducing a dedicated analysis protocol and a corresponding template that outputs an investigation report.

Changes:

  • Added a new analysis protocol for systematic simulation setup/results/constraint/corner/model review.
  • Added a new validate-simulation template that composes guardrails + the new protocol and outputs an investigation report.
  • Registered the new protocol/template in manifest.yaml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
templates/validate-simulation.md New template to review simulation output vs requirements using investigation-report output.
protocols/analysis/simulation-validation.md New 6-phase analysis protocol for simulation validation methodology.
manifest.yaml Registers the new protocol and template for bootstrap/assembly and CI validation.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@Alan-Jowett Alan-Jowett merged commit d2296db into microsoft:main Mar 29, 2026
6 checks passed
@Alan-Jowett Alan-Jowett deleted the add-simulation-validation branch March 29, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants