Repository navigation
TEST: Stabilize scenario estimate readiness coordination - #3364
Merged
Roman Lutz (romanlutz) merged 2 commits intoOct 20, 2026
Merged
Roman Lutz (romanlutz) merged 2 commits into
Roman Lutz (romanlutz) merged 2 commits into
Conversation
Observe queued catalog admission explicitly and verify configured estimates complete while catalog capacity is occupied. Reuse the finite estimate test watchdog and drain owned work on all exit paths without changing production deadlines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 73d7c38f-5387-4c8d-b0ac-9fba6a515449
varunj-msft
approved these changes
Oct 20, 2026
Count successful catalog admissions before each execution timeout starts, and spy on catalog semaphore acquisition during configured estimates. Address both review suggestions without adding latency assertions or changing production behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 73d7c38f-5387-4c8d-b0ac-9fba6a515449
Roman Lutz (romanlutz)
deleted the
romanlutz-scenario-estimate-readiness-fix
branch
October 20, 2026 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two scenario estimate tests still impose one-second readiness/completion limits that can fail on busy runners. These waits were not covered by #3273. Both tests pass on an ordinary fresh-main run, but controlled 1.1-second fake-worker delays reproduce the failures reported in the catalog readiness job and the configured completion job.
finally, and assert task cleanup.Production code and deadlines are unchanged. No retries, skips, or weaker semantic assertions are introduced.
Tests and Documentation
Updated the two assigned estimate tests and documented their coordination and cleanup pattern in
doc/contributing/4_running_tests.md.uv run --frozen python -m pytest tests\unit\backend\test_scenario_service.py -q: 78 passed, with 9 existing dataset deprecation warnings.uv run --frozen ruff check tests\unit\backend\test_scenario_service.py: passed.uv run --frozen ruff format --check tests\unit\backend\test_scenario_service.py: passed.git --no-pager diff --check HEAD^ HEAD: passed.Additional offline probes, kept outside the repository, reproduced the old readiness and configured-completion failures with delayed mocked workers. Both repaired tests pass the same delays without leaked estimates. In-memory fault injection confirmed that the tests still reject deadlines started before admission and configured work sharing catalog capacity; failure-path cleanup also passed. No live providers were used.
JupyText: not run; no notebooks or executable documentation changed.