'Database Tools' integration refactoring & Open Redis cache in 'Database' tool window#9421
Open
ilnarag wants to merge 5 commits intomicrosoft:developfrom
Open
'Database Tools' integration refactoring & Open Redis cache in 'Database' tool window#9421ilnarag wants to merge 5 commits intomicrosoft:developfrom
ilnarag wants to merge 5 commits intomicrosoft:developfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="JetBrains" |
Contributor
Author
|
@wangmingliang-ms, could you please take a look? |
Collaborator
|
@ilnarag thanks for your contributing, sorry that we are busy on some other projects recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, we decided to implement the opening of Redis caches in the 'Database' tool window. During the implementation of this feature, we discovered duplicate code related to the 'Database Tools' integration. As a result, we chose to move this code into a separate module called 'azure-intellij-plugin-dbtools' and unify the logic across the 'azure-intellij-plugin-cosmos' and 'azure-intellij-plugin-database' modules. This same logic will also be reused for Redis caches.