Add TimeProvider support to orchestration analyzer #573
+281
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: YunchuWang <[email protected]>
Co-authored-by: YunchuWang <[email protected]>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| CultureInfo.InvariantCulture, | ||
| Resources.UseInsteadFixerTitle, | ||
| recommendation, | ||
| dateTimeExpression.ToString()); |
| CultureInfo.InvariantCulture, | ||
| Resources.UseInsteadFixerTitle, | ||
| recommendation, | ||
| timeProviderInvocation.ToString()); |
Comment on lines
+74
to
+109
| else if (orchestrationContext.SyntaxNodeWithDiagnostic is InvocationExpressionSyntax timeProviderInvocation) | ||
| { | ||
| // For DateTime, we may need to add .Date for Today | ||
| string dateTimeTodaySuffix = isDateTimeToday ? ".Date" : string.Empty; | ||
| recommendation = $"{contextParameterName}.CurrentUtcDateTime{dateTimeTodaySuffix}"; | ||
| } | ||
| // Determine the method being called | ||
| if (semanticModel.GetSymbolInfo(timeProviderInvocation).Symbol is IMethodSymbol methodSymbol) | ||
| { | ||
| string methodName = methodSymbol.Name; | ||
|
|
||
| // Check if the method returns DateTimeOffset | ||
| bool returnsDateTimeOffset = methodSymbol.ReturnType.ToDisplayString() == "System.DateTimeOffset"; | ||
|
|
||
| // e.g: "Use 'context.CurrentUtcDateTime' instead of 'DateTime.Now'" | ||
| // e.g: "Use 'context.CurrentUtcDateTime.Date' instead of 'DateTime.Today'" | ||
| // e.g: "Use '(DateTimeOffset)context.CurrentUtcDateTime' instead of 'DateTimeOffset.Now'" | ||
| string title = string.Format( | ||
| CultureInfo.InvariantCulture, | ||
| Resources.UseInsteadFixerTitle, | ||
| recommendation, | ||
| dateTimeExpression.ToString()); | ||
|
|
||
| context.RegisterCodeFix( | ||
| CodeAction.Create( | ||
| title: title, | ||
| createChangedDocument: c => ReplaceDateTime(context.Document, orchestrationContext.Root, dateTimeExpression, contextParameterName, isDateTimeToday, isDateTimeOffset), | ||
| equivalenceKey: title), // This key is used to prevent duplicate code fixes. | ||
| context.Diagnostics); | ||
| // Build the recommendation based on the method name | ||
| string recommendation = methodName switch | ||
| { | ||
| "GetUtcNow" when returnsDateTimeOffset => $"(DateTimeOffset){contextParameterName}.CurrentUtcDateTime", | ||
| "GetUtcNow" => $"{contextParameterName}.CurrentUtcDateTime", | ||
| "GetLocalNow" when returnsDateTimeOffset => $"(DateTimeOffset){contextParameterName}.CurrentUtcDateTime.ToLocalTime()", | ||
| "GetLocalNow" => $"{contextParameterName}.CurrentUtcDateTime.ToLocalTime()", | ||
| "GetTimestamp" => $"{contextParameterName}.CurrentUtcDateTime.Ticks", | ||
| _ => $"{contextParameterName}.CurrentUtcDateTime", | ||
| }; | ||
|
|
||
| // e.g: "Use 'context.CurrentUtcDateTime' instead of 'TimeProvider.System.GetUtcNow()'" | ||
| string title = string.Format( | ||
| CultureInfo.InvariantCulture, | ||
| Resources.UseInsteadFixerTitle, | ||
| recommendation, | ||
| timeProviderInvocation.ToString()); | ||
|
|
||
| context.RegisterCodeFix( | ||
| CodeAction.Create( | ||
| title: title, | ||
| createChangedDocument: c => ReplaceTimeProvider(context.Document, orchestrationContext.Root, timeProviderInvocation, contextParameterName, methodName, returnsDateTimeOffset), | ||
| equivalenceKey: title), | ||
| context.Diagnostics); | ||
| } | ||
| } |
Co-authored-by: YunchuWang <[email protected]>
Copilot
AI
changed the title
[WIP] Add Roslyn Analyzer support for System.TimeProvider
Add TimeProvider support to orchestration analyzer
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orchestration analyzer detects non-deterministic DateTime/DateTimeOffset usage but didn't cover
System.TimeProvider(available in .NET 8+), leaving a gap in determinism validation.Changes
DateTimeOrchestrationAnalyzerto detectTimeProvider.GetUtcNow(),GetLocalNow(), andGetTimestamp()invocations using the existingDURABLE0001diagnosticDateTimeOrchestrationFixerto replace TimeProvider calls withcontext.CurrentUtcDateTime, adding DateTimeOffset casts where the original method returned that typeExample
Before (triggers warning):
After (code fix applied):
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.