Open
Conversation
- Replace hardcoded .kusto.windows.net with environment-aware lookup map covering AzureCloud, AzureUSGovernment, AzureChinaCloud with fallback heuristic for unknown clouds - Fix China ADX suffix: kusto.windows.cn (not kusto.chinacloudapi.cn) - Add openDataBaseUrl parameter for sovereign open-data ingestion (main.bicep → hub.bicep → Analytics/app.bicep) - Auto-skip ADF GitHub resources when open data is local storage - Fix createUiDefinition regex to accept all cloud storage suffixes - Replace 27 hardcoded portal.azure.com URLs in dashboard.json with build-time variable token - Add -PortalUrl parameter to Build-Toolkit.ps1 - Clear hardcoded clusterUri in dashboard.json (user configures post-import) - Fix gitapp.hub.com typo in ADF linked service URL - Add SOVEREIGN-CLOUD-GUIDE.md: deployment workflow, suffix inventory, prerequisites, verified against Microsoft Learn docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add deploy-sovereign.md: Microsoft Learn how-to guide for sovereign cloud deployments (US Government, China, other sovereign environments) - deploy-sovereign.md follows deploy.md conventions: front matter, tab selectors, admonitions, nextstepaction blocks, related content Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds sovereign cloud support to FinOps Hubs, enabling deployment to Azure US Government, Azure China (21Vianet), and other sovereign environments.
Changes
Bicep template changes (
src/templates/finops-hub/).kusto.windows.netwith an environment-aware lookup map covering AzureCloud, AzureUSGovernment, and AzureChinaCloud, with areplace()fallback heuristic for unknown clouds. Fixes an incorrect China suffix (kusto.chinacloudapi.cn→kusto.windows.cn).openDataBaseUrlparameter (threaded throughmain.bicep→hub.bicep→Analytics/app.bicep) so sovereign environments without internet access can point to a local storage account instead of GitHub.openDataBaseUrlpoints to the hub's own storage account.createUiDefinition.jsonregex to accept storage suffixes from all clouds (not just.windows.net).portal.azure.comURLs indashboard.jsonwith a build-time$$defined-portal-url$$token.clusterUri— users configure it to their cluster after import.-PortalUrlparameter toBuild-Toolkit.ps1(defaults tohttps://portal.azure.com).gitapp.hub.comtypo in ADF linked service URL →github.com.Documentation (
docs-mslearn/toolkit/hubs/)deploy-sovereign.md: New Microsoft Learn how-to guide covering build, open-data preparation, deployment, and dashboard configuration for sovereign clouds. Followsdeploy.mdconventions (front matter, tab selectors, admonitions, related content).Testing
bicep build main.bicep).kusto.windows.net,portal.azure.com,logic.azure.com, orgitapp.hub.comin changed filesChecklist
src/templates/finops-hub/onlydeploy-sovereign.mdmatchesdeploy.mdformat conventions