Creating react-file-type-icons package for v9#35515
Creating react-file-type-icons package for v9#35515bigbadcapers wants to merge 165 commits intomicrosoft:masterfrom
Conversation
…ileextension based filetype icons.
…/bigbadcapers/fluentui into caperez/sep-filetype-icon-update
…ethod used for file extensions
# Conflicts (merged and resolved): # packages/react-file-type-icons/src/FileIconType.ts # packages/react-file-type-icons/src/FileTypeIconMap.ts # packages/react-file-type-icons/src/getFileTypeIconProps.ts
… wrapped in an if statement to filter unwanted properties from the prototype guard-for-in
…asks, and exploring workspaces - Introduced `nx-generate` skill for scaffolding projects and code generation using Nx generators. - Added `nx-plugins` skill to discover and install Nx plugins for various frameworks. - Created `nx-run-tasks` skill to assist in executing tasks within an Nx workspace. - Developed `nx-workspace` skill for exploring workspace structure, project configurations, and available targets. - Added references for affected projects in the workspace. - Updated VSCode settings for improved terminal history and session management. - Enhanced guidelines for working with Nx, emphasizing the use of skills for scaffolding and exploration. - Updated Storybook configuration to ensure visibility of specific component documentation. - Added mock for `@fluentui/set-version` to prevent errors in Storybook.
…or-v9 (match source tree)
|
Just rebuilt the approach entirely to actually add v9 calling patterns into the existing file type icons package instead of having two competing packages with same major version number. |
…ean the package should be moved into the packages/react-components folder? and will that have negative effects for v8 usages?
|
So the PR now integrates cleanly and i tested both the v9 storybook and older v8 stories, both methods of referencing file type icons work without the need for separate packages. I did not move the location of the package and that seemed to cause a CI error until this line was added: https://github.com/bigbadcapers/fluentui/blob/829bcbd1638c7b55b504a14fde65d24ce8f89b5e/package.json#L337 It's the one thing that stands out as odd to me now, but I dont know if actually moving the package's folder to where the rest of the v9 controls are would have worse side-effects, and I'm trying to minimize impact to the overall # of files touched. Please lmk what's the best approach here. |
3 participants
masterbranchyarn changelocally