Set source to null when unavailable in StackTrace#614
Merged
chagong merged 1 commit intomicrosoft:mainfrom Nov 24, 2025
Merged
Conversation
playdohface
requested review from
chagong,
jdneo,
testforstephen and
wenytang-ms
as code owners
Contributor
|
LGTM. |
chagong
approved these changes
Nov 24, 2025
mfussenegger
added a commit
to mfussenegger/java-debug
that referenced
this pull request
Dec 4, 2025
Follow up to: - microsoft#614 - microsoft#609 With the change to set the line number to 0 the jdiLineNumber != lspFrame.line comparison can evaluate to true: dap> lspFrame Types$StackFrame@78 column: 1 id: 6 line: 0 name: "0x000000002f0bc000.invokeVirtual(Object,Object)" presentationHint: "subtle" source: null dap> jdiLineNumber -1 `source` being null caused an NPE
chagong
added a commit
that referenced
this pull request
Dec 9, 2025
* Fix lspFrame.source NPE on stackTrace request Follow up to: - #614 - #609 With the change to set the line number to 0 the jdiLineNumber != lspFrame.line comparison can evaluate to true: dap> lspFrame Types$StackFrame@78 column: 1 id: 6 line: 0 name: "0x000000002f0bc000.invokeVirtual(Object,Object)" presentationHint: "subtle" source: null dap> jdiLineNumber -1 `source` being null caused an NPE * Fix line number comparison in StackTraceRequestHandler --------- Co-authored-by: Changyong Gong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by @mfussenegger in #609 it's probably more correct and in the spirit of the spec to keep the
sourceasnullwhen it is not unavailable instead of setting it to a special value, especially since it would break nvim-dap otherwise.