fix: implement NOT operator with LINQ post-filtering#1109
Merged
Conversation
The NOT operator now works correctly using a hybrid FTS + LINQ approach: - FTS5 handles positive terms only - NOT terms are excluded via LINQ post-filtering - Standalone NOT queries now work (previously crashed) Changes: - Add FtsQueryResult record to separate FTS query from NOT terms - Modify FtsQueryExtractor to collect NOT terms separately - Add ApplyNotTermFiltering for LINQ exclusion - Add GetAllDocumentsAsync for standalone NOT queries - Add 7 E2E tests for NOT operator scenarios - Mark known issue as resolved in KNOWN-ISSUES.md Usage note: Use explicit AND between terms, e.g., "foo AND NOT bar"
The tokenizer now handles both double-quoted ("...") and single-quoted
('...') strings. Previously, single quotes were treated as part of
identifiers, causing NOT 'AND' to search for literal "'AND'" instead
of "AND".
Keep only open issues. Resolved issues don't need to be tracked here.
Show how to exclude terms with NOT and standalone NOT queries.
4741a42 to
fdcdf7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the NOT operator issues - the NOT operator now works correctly using a hybrid FTS + LINQ approach.
Problem
The NOT operator had two problems:
km search "NOT foo"threw FTS5 syntax errorkm search "foo AND NOT bar"returned documents containing bothSolution
Hybrid FTS + LINQ filtering:
Changes
src/Core/Search/NodeSearchService.cs:FtsQueryResultrecord to separate FTS query from NOT termsFtsQueryExtractorto collect NOT terms separatelyApplyNotTermFiltering()for LINQ exclusionsrc/Core/Search/SqliteFtsIndex.cs:GetAllDocumentsAsync()for standalone NOT queriessrc/Core/Search/Query/Parsers/InfixQueryParser.cs:'AND'as literal with quotes)src/Main/CLI/Commands/ExamplesCommand.cs:tests/Core.Tests/Search/SearchEndToEndTests.cs:KNOWN-ISSUES.md: Cleaned up, only open issues remainUsage
Note: Use explicit AND between terms (e.g.,
foo AND NOT bar)Test plan
build.shpasses with 0 warningsformat.shpasses