fix: use unique IDs to prevent instance collisions across bundles#126
Open
layershifter wants to merge 4 commits intomicrosoft:mainfrom
Open
fix: use unique IDs to prevent instance collisions across bundles#126layershifter wants to merge 4 commits intomicrosoft:mainfrom
layershifter wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Adds the "exports" field to prevent deep importing of internal modules. Closes microsoft#21. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the module-scoped _lastId counter with crypto.getRandomValues() to generate unique IDs. This prevents ID collisions when multiple bundles include keyborg on the same page. Closes microsoft#99 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test doesn't accurately simulate the multi-bundle scenario described in the issue since it uses the same module scope for both instances. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📊 Bundle size reportUnchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
_lastIdcounter withcrypto.getRandomValues()to generate unique instance IDs_lastIdstarting at 0, causing ID collisions in the sharedwindow.__keyborg.refsmapcrypto.getRandomValues()(notcrypto.randomUUID()) to support Edge 84+, Firefox 75+, Chrome 84+, Safari 14.1+Closes #99
Supersedes #75 and #104
Test plan
npm run buildpassesnpm run lintpasses🤖 Generated with Claude Code