Skip to content

Add per-session OP-TEE client identity handling#885

Open
sangho2 wants to merge 6 commits into
mainfrom
sanghle/optee/fix_client_identity
Open

Add per-session OP-TEE client identity handling#885
sangho2 wants to merge 6 commits into
mainfrom
sanghle/optee/fix_client_identity

Conversation

@sangho2

@sangho2 sangho2 commented May 29, 2026

Copy link
Copy Markdown
Contributor

This PR adds support for handling OP-TEE client identity per session not per instance. Default client identity is now Public not User. It also does some additional sanity checks.

@sangho2 sangho2 marked this pull request as ready for review May 29, 2026 23:45
@sangho2 sangho2 marked this pull request as draft May 29, 2026 23:52
@sangho2 sangho2 added the must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes. label May 29, 2026
@sangho2

sangho2 commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

We should merge #865 first because this PR should have one more fix: per-session ClientIdenty rather than per-instance ClientIdentity. #865 heavily refactored related data structures and functions.

@sangho2 sangho2 force-pushed the sanghle/optee/fix_client_identity branch from a74c65c to 3e234d1 Compare June 26, 2026 04:58
@sangho2 sangho2 removed the must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes. label Jun 26, 2026
@sangho2 sangho2 changed the title Fix OP-TEE client identity handling Fix OP-TEE client identity and session identifier storage Jun 26, 2026
@sangho2 sangho2 changed the title Fix OP-TEE client identity and session identifier storage Add per-session OP-TEE client identity handling Jun 26, 2026
@sangho2 sangho2 force-pushed the sanghle/optee/fix_client_identity branch from bc2ff08 to 4df48ea Compare June 26, 2026 17:09
@github-actions

Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron

Failed in:
  variant TeeLogin:ReeKernel in /home/runner/work/litebox/litebox/litebox_common_optee/src/lib.rs:859

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron

Failed in:
  OpteeShimEntrypoints::get_session_id, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/57bd142707cd1f41b3b99c75722ba483bb394692/litebox_shim_optee/src/lib.rs:328

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron

Failed in:
  litebox_shim_optee::OpteeShim::load_ldelf takes 5 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-main/57bd142707cd1f41b3b99c75722ba483bb394692/litebox_shim_optee/src/lib.rs:232, but now takes 3 parameters in /home/runner/work/litebox/litebox/litebox_shim_optee/src/lib.rs:238

@sangho2 sangho2 marked this pull request as ready for review June 26, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant