fix: support YouTube short URLs and Shorts in YouTubeConverter#1776
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: support YouTube short URLs and Shorts in YouTubeConverter#1776Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Accepts youtu.be/ short URLs and youtube.com/shorts/ URLs - Extracts video ID from all URL formats for transcript fetching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I noticed that the YouTubeConverter.accepts() method only matches URLs that begin with
https://www.youtube.com/watch?and silently rejects:https://youtu.be/dQw4w9WgXcQhttps://www.youtube.com/shorts/...This means these URLs were never converted through the YouTube converter — they would fall through to a generic HTML converter, producing noisy output instead of a clean transcript.
Changes
accepts()method to recognize short URLs and shorts URLsconvert()to handle all URL formatsThis fix is related to issue #1730 which mentions this problem.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof