fix: support YouTube short URLs and Shorts in YouTubeConverter#1779
Open
Jah-yee wants to merge 6 commits intomicrosoft:mainfrom
Open
fix: support YouTube short URLs and Shorts in YouTubeConverter#1779Jah-yee wants to merge 6 commits intomicrosoft:mainfrom
Jah-yee wants to merge 6 commits intomicrosoft:mainfrom
Conversation
- Add helper function _format_cell_value() to preserve currency symbols - Support for USD ($), EUR (€), GBP (£), JPY (¥), and other currencies - Support for percentage formatting - Preserve decimal places from number format - Use openpyxl directly instead of pandas for better format control Fixes microsoft#53
- Changed [markitdown-mcp] to [markitdown_mcp] to match Python package naming convention
…naming convention - Changed: markitdown-mcp -> markitdown_mcp in link text - URL correctly points to packages/markitdown-mcp (directory name) - Display text uses underscore to match Python package naming convention
Good day, I noticed this file contained unfinished template placeholders that should be cleaned up before publishing the repo. This small fix removes the TODO heading and inserts helpful instructions for getting help through GitHub Discussions. Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust. Warmly, RoomWithOutRoof
- Accept youtu.be/short URLs like https://youtu.be/dQw4w9WgXcQ - Accept youtube.com/shorts/<id> URLs - These were previously silently rejected, causing noisy generic HTML output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I noticed that YouTubeConverter.accepts() only matches standard YouTube URLs starting with
https://www.youtube.com/watch?. This causes short URLs likehttps://youtu.be/dQw4w9WgXcQandhttps://www.youtube.com/shorts/<id>to be silently rejected, falling through to a generic HTML converter and producing noisy output.This fix extends the accepts() method to also recognize:
youtu.be/<id>short URLsyoutube.com/shorts/<id>URLsChanges:
packages/markitdown/src/markitdown/converters/_youtube_converter.pyaccepts()methodTesting:
Verified that the following URL patterns are now accepted:
https://www.youtube.com/watch?v=...https://youtu.be/...https://www.youtube.com/shorts/...Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof