fix(chromium): gracefully handle unsupported Browser.setDownloadBehavior on CDP#40264
Closed
geun9716 wants to merge 2 commits intomicrosoft:mainfrom
Closed
fix(chromium): gracefully handle unsupported Browser.setDownloadBehavior on CDP#40264geun9716 wants to merge 2 commits intomicrosoft:mainfrom
geun9716 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…ior on CDP connect - add exception handling on Browser.setDownloaBehavior to avoid on specific platform
Member
|
#40185 is a better fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When connecting to a remote browser via CDP (--cdp option), some embedded Chromium-based browsers do not implement the full Chrome DevTools Protocol. One common example is LG webOS TV, which exposes a remote Web Inspector via CDP but does not support Browser.setDownloadBehavior.
Currently, Playwright sends Browser.setDownloadBehavior unconditionally during CRBrowserContext.initialize(). If the remote browser rejects this command, the entire CDP connection fails with:
Error: Protocol error (Browser.setDownloadBehavior): Browser context management is not supported.This blocks any use of Playwright for debugging, testing, or automation on these devices, even though download behavior management is irrelevant in that context.
Change
File: packages/playwright-core/src/server/chromium/crBrowser.ts
In CRBrowserContext.initialize(), catch the ProtocolError from Browser.setDownloadBehavior using the existing isProtocolError utility and match on e.method, then log at debug level. Any other unexpected errors are re-thrown.
Tested On
LG webOS TV (Cast shell remote debugging via CDP)
Standard Chrome (desktop) - No behavior change, download tests pass as before
references #40263