Bump node-forge to 1.4.0 & @types/node-forge to address CVEs#5738
Merged
iclanton merged 2 commits intomicrosoft:mainfrom Apr 1, 2026
Merged
Bump node-forge to 1.4.0 & @types/node-forge to address CVEs#5738iclanton merged 2 commits intomicrosoft:mainfrom
iclanton merged 2 commits intomicrosoft:mainfrom
Conversation
iclanton
reviewed
Apr 1, 2026
Member
|
How was this tested? |
Contributor
Author
Updating the description |
Upgrade @types/node-forge from 1.0.4 to 1.3.14 to match the node-forge 1.4.0 bump. The newer types widen pki.PrivateKey to pki.rsa.PrivateKey | Buffer, so cast to pki.rsa.PrivateKey at the two certificate.sign() call sites — safe since both keys come from forge.pki.rsa.generateKeyPair(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
18ec8a4 to
1c76040
Compare
iclanton
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 4 CVEs:
Smoke testing