Guard MarshalByRefObject, [Serializable], and InitializeLifetimeService behind #if NETFRAMEWORK by Evangelink · Pull Request #8174 · microsoft/testfx

Evangelink · 2026-05-13T10:41:45Z

Summary

Audit and clean up MarshalByRefObject and [Serializable] usage across src/ to ensure these .NET Framework remoting artifacts are properly scoped to net462 only.

Changes

`MarshalByRefObject` inheritance (10 classes)

Made all MarshalByRefObject base class inheritance conditional on #if NETFRAMEWORK:

Classes with only MarshalByRefObject as base (6):

AssemblyEnumerator, ReflectHelper, RecursiveDirectoryPath, UnitTestRunner, TypeCache, TestAssemblySettingsProvider

Classes implementing MarshalByRefObject + an interface (4):

RemotingMessageLogger, NopTraceLogger, EqtTraceLogger, MTPTraceLogger

`InitializeLifetimeService` overrides (6 methods)

Wrapped all InitializeLifetimeService() overrides (including [SecurityCritical] and the previous [Obsolete] attributes) entirely in #if NETFRAMEWORK. On net462, the override returns null for infinite lifetime. On modern .NET, the override doesn't exist since the base class is no longer MarshalByRefObject.

Also conditionally included using System.Security; to avoid IDE0005 warnings.

`[Serializable]` attribute (11 non-exception types)

Guarded [Serializable] with #if NETFRAMEWORK on data types that only needed it for BinaryFormatter marshaling across AppDomain boundaries:

RecursiveDirectoryPath, UnitTestElement, TestMethod, TestAssemblySettings, StackTraceInformation, MSTestSettings, AssemblyEnumerationResult, TestRunDirectories, DeploymentItem, DeploymentItemOriginType, TestResult

Exception types (AssertFailedException, UnitTestAssertException, etc.) intentionally retain [Serializable] unconditionally — this is a standard .NET convention for exceptions.

Already correctly guarded (no changes needed)

These were already behind #if NETFRAMEWORK:

AssemblyLoadWorker, StaticStateHelper (in AppDomainUtilities.cs), AssemblyResolver (conditional base class)
All AppDomain.CreateDomain/Unload calls in AppDomainUtilities.cs, AppDomainWrapper.cs, IAppDomain.cs, TestSourceHost.cs

Result

On modern .NET (net8.0/net9.0), these classes are now plain types with no remoting or BinaryFormatter baggage. On net462, the full AppDomain marshaling support is preserved.

Validation

✅ dotnet build net9.0 — 0 warnings, 0 errors
✅ dotnet build net462 — 0 warnings, 0 errors
✅ dotnet build MSTest.TestAdapter net9.0 — 0 warnings, 0 errors
✅ dotnet build TestFramework net9.0 — 0 warnings, 0 errors

…ce behind #if NETFRAMEWORK - Make all MarshalByRefObject inheritance conditional on NETFRAMEWORK across 10 classes - Wrap InitializeLifetimeService overrides and [SecurityCritical] in #if NETFRAMEWORK - Guard [Serializable] with #if NETFRAMEWORK on 11 non-exception data types - Conditionally include 'using System.Security' only for NETFRAMEWORK - Exception types retain [Serializable] unconditionally (standard .NET convention) On modern .NET (net8.0/net9.0), these classes are now plain types with no remoting or BinaryFormatter baggage. On net462, the full AppDomain marshaling support is preserved.

Copilot

Pull request overview

This PR scopes .NET Framework remoting/serialization artifacts (MarshalByRefObject, [Serializable], and InitializeLifetimeService) to #if NETFRAMEWORK, keeping AppDomain marshaling behavior on net462 while removing remoting-related baggage from modern .NET builds.

Changes:

Guarded MarshalByRefObject inheritance and InitializeLifetimeService() overrides behind #if NETFRAMEWORK.
Guarded [Serializable] on non-exception transport/data types behind #if NETFRAMEWORK.
Conditionally included using System.Security; only where [SecurityCritical] is compiled to avoid unused-using warnings.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Attributes/TestMethod/TestResult.cs	Makes `TestResult` `[Serializable]` only on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/RecursiveDirectoryPath.cs	Guards `[Serializable]`, `MarshalByRefObject`, `InitializeLifetimeService`, and `System.Security` usage to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/UnitTestElement.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/TestMethod.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/TestAssemblySettings.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/StackTraceInformation.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/NopTraceLogger.cs	Makes `MarshalByRefObject` base conditional for .NET Framework remoting.
src/Adapter/MSTestAdapter.PlatformServices/MSTestSettings.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Helpers/ReflectHelper.cs	Makes `MarshalByRefObject`/`InitializeLifetimeService` and `System.Security` usage conditional on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Execution/UnitTestRunner.cs	Makes `MarshalByRefObject`/`InitializeLifetimeService` and `System.Security` usage conditional on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Execution/TypeCache.cs	Makes `MarshalByRefObject`/`InitializeLifetimeService` and `System.Security` usage conditional on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestExecutionManager.cs	Makes nested `RemotingMessageLogger` inherit `MarshalByRefObject` only on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestAssemblySettingsProvider.cs	Makes `MarshalByRefObject`/`InitializeLifetimeService` and `System.Security` usage conditional on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs	Makes `MarshalByRefObject`/`InitializeLifetimeService` and `System.Security` usage conditional on .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerationResult.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Deployment/TestRunDirectories.cs	Guards `[Serializable]` to .NET Framework.
src/Adapter/MSTestAdapter.PlatformServices/Deployment/DeploymentItem.cs	Guards `[Serializable]` on enum and class to .NET Framework.
src/Adapter/MSTest.TestAdapter/VSTestAdapter/EqtTraceLogger.cs	Makes `MarshalByRefObject` base conditional for .NET Framework remoting.
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MTPTraceLogger.cs	Makes `MarshalByRefObject` base conditional for .NET Framework remoting.

Copilot's findings

Files reviewed: 19/19 changed files
Comments generated: 0

Youssef1313 · 2026-05-13T10:51:05Z

+#if NETFRAMEWORK
 [Serializable]
+#endif


Consider reverting and keep the changes only in Adapter, or at least have this under #if NETFRAMEWORK || NETSTANDARD to be safe. I would be worried if TestFramework netstandard assemblies end up getting loaded in a .NET Framework process where Serializable will be needed.

Under adapter, we no longer target .NET Standard so we are pretty safe there.

Actually better to simply just revert in this case.

This is a public class and we might not know what users are doing with it.

Evangelink · 2026-05-13T11:22:32Z

@copilot resolve the merge conflicts in this pull request

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-05-13T11:28:48Z

@copilot resolve the merge conflicts in this pull request

Resolved. The only conflict was in MSTestSettings.cs — the Refactor MSTestSettings into focused partial-class modules commit on main changed class MSTestSettings to partial class MSTestSettings, while this PR had added #if NETFRAMEWORK [Serializable] #endif around it. The resolution combines both: keeping partial and keeping the #if NETFRAMEWORK guard. Merge commit: 41b1475.

Removing [Serializable] for non-NETFRAMEWORK exposed an IDE0032 false positive on s_currentSettings/s_runConfigurationSettings, whose backing properties use '??=' lazy initialization (not expressible as an auto-property). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 19/19 changed files
Comments generated: 4

        return ResolveTestMethodInfoForDiscovery(testMethod, testClassInfo);
    }

+#if NETFRAMEWORK


-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
    public override object InitializeLifetimeService() => null!;



    /// <summary>
    /// Member variable for RunConfiguration settings.
    /// </summary>
    private static RunConfigurationSettings? s_runConfigurationSettings;
+#pragma warning restore IDE0032


+#pragma warning disable IDE0032 // Use auto property — property uses lazy '??=' initialization, which cannot be expressed as an auto-property.
    private static MSTestSettings? s_currentSettings;

    /// <summary>
    /// Member variable for RunConfiguration settings.
    /// </summary>
    private static RunConfigurationSettings? s_runConfigurationSettings;
+#pragma warning restore IDE0032


Youssef1313 · 2026-05-14T20:23:34Z

    /// <summary>
    /// Member variable for Adapter settings.
    /// </summary>
+#pragma warning disable IDE0032 // Use auto property — property uses lazy '??=' initialization, which cannot be expressed as an auto-property.


This suppression is not correct. You can use field keyword.

Copilot AI review requested due to automatic review settings May 13, 2026 10:41

Copilot started reviewing on behalf of Evangelink May 13, 2026 10:42 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Youssef1313 reviewed May 13, 2026

View reviewed changes

Copilot started work on behalf of Evangelink May 13, 2026 11:22 View session

Merge origin/main into dev/amauryleve/guard-netfx-remoting-artifacts

41b1475

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot finished work on behalf of Evangelink May 13, 2026 11:29

Copilot started work on behalf of Evangelink May 13, 2026 11:33 View session

Copilot finished work on behalf of Evangelink May 13, 2026 11:37

Copilot AI review requested due to automatic review settings May 14, 2026 18:33

Copilot AI reviewed May 14, 2026

View reviewed changes

Copilot started reviewing on behalf of Evangelink May 14, 2026 19:02 View session

Youssef1313 reviewed May 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Guard MarshalByRefObject, [Serializable], and InitializeLifetimeService behind #if NETFRAMEWORK#8174

Guard MarshalByRefObject, [Serializable], and InitializeLifetimeService behind #if NETFRAMEWORK#8174
Evangelink wants to merge 3 commits into
mainfrom
dev/amauryleve/guard-netfx-remoting-artifacts

Evangelink commented May 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Youssef1313 May 13, 2026 •

edited

Loading

Uh oh!

Youssef1313 May 13, 2026

Uh oh!

Evangelink commented May 13, 2026

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Youssef1313 May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Evangelink commented May 13, 2026

Summary

Changes

MarshalByRefObject inheritance (10 classes)

InitializeLifetimeService overrides (6 methods)

[Serializable] attribute (11 non-exception types)

Already correctly guarded (no changes needed)

Result

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Youssef1313 May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Youssef1313 May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Evangelink commented May 13, 2026

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Youssef1313 May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`MarshalByRefObject` inheritance (10 classes)

`InitializeLifetimeService` overrides (6 methods)

`[Serializable]` attribute (11 non-exception types)

Youssef1313 May 13, 2026 •

edited

Loading