DRAFT: feature: enable manual rollback #381
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
bfjelds
commented
Dec 5, 2025
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
from
5fc0ede to
08fe5bd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
2 times, most recently
from
be43d26 to
aceb17f
Compare
bfjelds
commented
Dec 18, 2025
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bfjelds
commented
Dec 18, 2025
| } | ||
|
|
||
| /// Sets the LoaderEntryDefault EFI variable to the previous boot entry. | ||
| pub fn set_default_to_previous() -> Result<(), TridentError> { |
Member
Author
There was a problem hiding this comment.
i wonder if we should construct the expected value rather than reading the "previous" value from the boot order.
bfjelds
commented
Dec 18, 2025
…NOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
2: eno1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
link/ether 94:57:a5:ed:84:f6 brd ff:ff:ff:ff:ff:ff
altname enp0s31f6
inet 10.137.188.68/22 metric 100 brd 10.137.191.255 scope global dynamic eno1
valid_lft 519614sec preferred_lft 519614sec
inet6 2001:4898:d8:32:9657:a5ff:feed:84f6/64 scope global dynamic mngtmpaddr noprefixroute
valid_lft 2591979sec preferred_lft 604779sec
inet6 fe80::9657:a5ff:feed:84f6/64 scope link
valid_lft forever preferred_lft forever
3: virbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 52:54:00:96:68:8a brd ff:ff:ff:ff:ff:ff
inet 192.168.122.1/24 brd 192.168.122.255 scope global virbr0
valid_lft forever preferred_lft forever
5: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
link/ether 22:21:7a:79:fa:d7 brd ff:ff:ff:ff:ff:ff
inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0
valid_lft forever preferred_lft forever
inet6 fe80::2021:7aff:fe79:fad7/64 scope link
valid_lft forever preferred_lft forever
2194: virbr1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 52:54:00:fc:46:a5 brd ff:ff:ff:ff:ff:ff
inet 192.168.242.1/24 brd 192.168.242.255 scope global virbr1
valid_lft forever preferred_lft forever
2196: vnet562: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master virbr1 state UNKNOWN group default qlen 1000
link/ether fe:54:00:0b:3e:95 brd ff:ff:ff:ff:ff:ff
inet6 fe80::fc54:ff:fe0b:3e95/64 scope link
valid_lft forever preferred_lft forever
2242: vnet566: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master virbr0 state UNKNOWN group default qlen 1000
link/ether fe:54:00:64:e9:40 brd ff:ff:ff:ff:ff:ff
inet6 fe80::fc54:ff:fe64:e940/64 scope link
valid_lft forever preferred_lft forever as well
bfjelds
force-pushed
the
user/bfjelds/manual-rollback
branch
from
fe859c1 to
55f30c1
Compare
Member
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
trident rollbackto provide manual rollback. Does not allow rollback for A/B updates involving encryption currently.CLI changes
trident rollback--ab: rollback available A/B update--runtime: rollback next update if it is runtime update--check: show what next rollback is:none|ab|runtimetrident get--rollback-chain: list all available rollbacks--rollback-target: display next rollback Host ConfigurationAPI changes
Host Statustrident_version: displays version of Trident that made the Host Status entry