Create COSI 1.2 with fields needed for 'baremetal images' #393
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces COSI specification version 1.2 to support baremetal image workflows by preserving partition table metadata during VHD to COSI conversion. The changes add four new required fields to the ImageFile object that capture original partition characteristics.
Key changes:
- Add COSI version 1.2 to the revision summary with spec date 2025-12-10
- Extend
ImageFileobject with partition metadata fields:originalSize,partUuid,partLabel, andpartNumber - Update documentation to clarify that
ImageFileobjects represent disk partitions with both content and partition table information
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cwize1
requested changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
cwize1
requested changes
Dec 11, 2025
frhuelsz
reviewed
Dec 12, 2025
frhuelsz
reviewed
Dec 12, 2025
frhuelsz
previously approved these changes
Dec 17, 2025
fintelia
commented
Dec 17, 2025
Contributor
Author
fintelia
left a comment
fintelia
left a comment
There was a problem hiding this comment.
Add discussion from API design meeting
frhuelsz
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new fields to COSI so that we can avoid losing information when converting VHD -> COSI. Specifically, it adds information from the disk partition table that may be important, like what the part UUIDs were and what order the partitions appeared on disk.
The plan is for
trident stream-imageto honor these additional fields whiletrident installwould continue its current approach of generating new random UUIDs and create partitions in the order specified in the Host Configuration.