Cloud Session - use working set to show changes in favour of the multi-diff chat response part #2619
+18
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-diff chat response part
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how file changes are displayed in cloud sessions by using the working set (ChatSessionItem.changes) instead of streaming multi-diff parts in the chat response. The change simplifies the architecture by getting repository information directly from the PullRequestSearchItem instead of requiring Git service lookups.
Key Changes:
- File changes are now populated in the ChatSessionItem's
changesfield usingChatSessionChangedFileobjects from the multi-diff data - Removed redundant streaming of
ChatResponseMultiDiffPartfrom session completion handlers - Simplified
PullRequestFileChangesServiceto use repository info from the PR object directly instead of Git service lookups
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extension/chatSessions/vscode-node/pullRequestFileChangesService.ts | Removed IGitService dependency and getRepoId usage; now gets repository info directly from PullRequestSearchItem |
| src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts | Added logic to populate changes field with ChatSessionChangedFile array from multi-diff part; removed code that streamed multi-diff part on session completion |
| src/extension/chatSessions/vscode-node/copilotCloudSessionContentBuilder.ts | Removed IPullRequestFileChangesService dependency and logic that added multi-diff parts to response when session completed/failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In yesterday's meeting we have discussed bringing the local/cloud background agent sessions closer together. In order to provide a consistent experience to review changes produced by a background agent, I have updated the cloud agent session to use the working set to display the changes instead of the multi-diff chat response part. When these changes are merged, I will follow up with a PR in the GHPRI extension to move the Apply/Checkout actions.
As part of this change, I have also updated
getFileChangesMultiDiffPart()since it was favoring the owner/repo from the active repository which is not appropriate as one might have multiple repositories opened. When possible we should use the information available in the pull request model returned by GitHub.