Fix duplicate entries in .git/config for GitHub PRs - #8876
Merged
Alex Ross (alexr00) merged 4 commits intoAug 12, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot stopped work on behalf of
Alex Ross (alexr00) due to an error
August 5, 2026 10:45
Member
|
Copilot continue |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Contributor
Author
Continued in |
Alex Ross (alexr00)
approved these changes
Aug 12, 2026
Alex Ross (alexr00)
marked this pull request as ready for review
August 12, 2026 10:03
Alex Ross (alexr00)
enabled auto-merge (squash)
August 12, 2026 10:03
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #8871 where the extension’s PR/base-branch association metadata written into .git/config accumulates duplicate entries over time, by ensuring repeated associations don’t continually append additional values and by adding regression coverage for the expected behavior.
Changes:
- Add focused tests ensuring PR/base-branch metadata is replaced (not appended) across repeated calls and concurrent calls.
- Introduce a serialized
setConfighelper to avoid concurrent update races and to prevent repeated appends when the effective value is already correct. - Update
associateBranchWithPullRequestandassociateBaseBranchWithBranchto use the new helper.
Show a summary per file
| File | Description |
|---|---|
| src/test/github/pullRequestGitHelper.test.ts | Adds regression tests for repeated/concurrent PR association and base-branch metadata replacement behavior. |
| src/github/pullRequestGitHelper.ts | Adds a serialized config update helper and routes PR/base-branch association writes through it to prevent unbounded duplicate config growth. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Dirk Bäumer (dbaeumer)
approved these changes
Aug 12, 2026
Alex Ross (alexr00)
deleted the
copilot/fix-duplicate-github-pr-configs
branch
August 12, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.