Conversation
edvilme
added
area-terminal
There was a problem hiding this comment.
Pull request overview
Adjusts the Python: Create Terminal command behavior to better support multi-root workspaces by selecting an appropriate Python project before creating a terminal.
Changes:
- Cache
api.getPythonProjects()and reuse it during terminal creation. - Update the project-picking flow in
createTerminalCommand. - Update
package-lock.jsonwith additionalpeermetadata entries.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/features/envCommands.ts | Updates project selection logic used when creating terminals. |
| package-lock.json | Adds peer: true metadata to multiple dependency entries. |
| if (context === undefined) { | ||
| const pw = await pickProject(api.getPythonProjects()); | ||
| const pythonProjects = api.getPythonProjects(); | ||
| if (context === undefined || pythonProjects.length > 0) { |
There was a problem hiding this comment.
The if (context === undefined || pythonProjects.length > 0) condition makes all subsequent else if branches effectively unreachable whenever there is at least one Python project. This causes the command to ignore the provided context (e.g., Uri/ProjectItem/PythonEnvTreeItem) and can create a terminal for a different environment/project than the one the user invoked the command on. Consider restoring the context-based branching (only enter the project-pick flow when context is undefined, or when you explicitly need to disambiguate between multiple projects) so that Uri/ProjectItem/PythonEnvTreeItem cases still behave correctly.
| if (context === undefined || pythonProjects.length > 0) { | |
| if (context === undefined) { |
| import { executeCommand } from '../common/command.api'; | ||
| import { clipboardWriteText } from '../common/env.apis'; | ||
| import {} from '../common/errors/utils'; | ||
| import { } from '../common/errors/utils'; |
There was a problem hiding this comment.
This is an empty named import (import { } from ...) and the target module only exports helpers (no side effects). This should be removed (or replaced with a side-effect-only import if a side effect is actually required) to avoid dead/unused imports.
| import { } from '../common/errors/utils'; |
Fixes #291