Fix absence of pytest kill in Cancel Test Run#25932
Open
kornevgen wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores initialization of the pytest subprocess handle in the pytest execution adapter so that “Cancel Test Run” can actually terminate an in-progress pytest run (regression described in #21507).
Changes:
- Reintroduces assigning the spawned pytest child process (
result?.proc) to a local variable used by the cancellation handler.
Show a summary per file
| File | Description |
|---|---|
| src/client/testing/testController/pytest/pytestExecutionAdapter.ts | Restores tracking of the pytest child process so cancellation can attempt to kill it. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
248
to
250
| const result = execService?.execObservable(runArgs, spawnOptions); | ||
| resultProc = result?.proc; | ||
|
|
Comment on lines
248
to
250
| const result = execService?.execObservable(runArgs, spawnOptions); | ||
| resultProc = result?.proc; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21507
Commit 354fcd6 has removed initialisation of
resultProcvariable. So cancelling can't kill pytest becauseresultProcis undefined. PR restores that initialisation.Tested by click on 'Cancel Test Run'. Reaction on cancelling has appeared immediately.
Label: bug