Repository navigation
agentHost: switch Auto routing preferences with the SDK - #335103
Merged
Logan Ramos (lramos15) merged 3 commits intoSep 8, 2026
Merged
Conversation
Base automatically changed from
roblou/agents/upgrade-vscode-github-copilot-1083
to
main
September 8, 2026 18:50
Forward Auto preferences and explicit resets through the SDK instead of pinning the launch profile. Unify Auto-tier settings across Copilot Chat and agent-host sessions, and align the picker and accessibility wording. Fixes #333809. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61130d6b-7319-480e-92d1-b6b08949e03a
Logan Ramos (lramos15)
force-pushed
the
lramos15/agents/auto-tier-sdk-switching
branch
from
September 8, 2026 19:24
99bae5c to
95bb9a8
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cross-component routing and persistence changes warrant final human review.
Review tier: Balanced
Findings: None
What changed in this PR
Updates Agent Host Auto routing to use SDK runtime-switchable preferences while aligning configuration and terminology across Copilot Chat.
Changes:
- Forwards Auto preferences through creation, resume, and
setModel. - Unifies Auto settings and experiment defaults.
- Updates UI terminology, accessibility guidance, and tests.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerHover.test.ts |
Tests updated hover labels. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostCopilotCliSettingsContribution.test.ts |
Tests shared setting forwarding. |
src/vs/workbench/contrib/chat/test/browser/accessibility/chatAccessibilityHelp.test.ts |
Tests revised accessibility guidance. |
src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerHover.ts |
Renames the Auto configuration label. |
src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerCard.ts |
Aligns Auto card terminology. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Registers shared Auto settings. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostCopilotCliSettingsContribution.ts |
Forwards shared settings to Agent Host. |
src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts |
Documents Auto preference interaction. |
src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.ts |
Covers creation, resume, overrides, and fallbacks. |
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts |
Covers SDK setModel options and resets. |
src/vs/platform/agentHost/test/node/copilotAgent.test.ts |
Covers switching, persistence, rejection, and isolation. |
src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts |
Resolves launch and resume preferences. |
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Passes Auto preferences through setModel. |
src/vs/platform/agentHost/node/copilot/copilotAgent.ts |
Removes launch pinning and persists requested choices. |
src/vs/platform/agentHost/common/copilotCliConfig.ts |
Defines shared root configuration. |
src/vs/platform/agentHost/common/autoModeTiers.ts |
Normalizes retired preference values. |
extensions/copilot/src/platform/endpoint/node/test/automodeService.spec.ts |
Tests effective shared-setting behavior. |
extensions/copilot/src/platform/endpoint/node/automodeService.ts |
Reads the workbench-owned setting. |
extensions/copilot/src/platform/configuration/common/configurationService.ts |
Reclassifies shared Auto settings. |
extensions/copilot/package.nls.json |
Removes superseded localization. |
extensions/copilot/package.json |
Removes duplicate setting registrations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Auto-tier support now reads the shared effective configuration, so remove the obsolete experimentation-service injection and assert that the regression test performs no separate experiment lookup. Fixes the extension typecheck failure on #335103. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61130d6b-7319-480e-92d1-b6b08949e03a
Keep the centralized Auto-tier settings in the existing shared configuration category rather than the extension-owned advanced category. Preserve their IDs and defaults, update consumers, and keep the strict package.json registration test unchanged. Fixes the remaining Copilot unit-test failure on #335103. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61130d6b-7319-480e-92d1-b6b08949e03a
Logan Ramos (lramos15)
marked this pull request as ready for review
September 8, 2026 21:12
Justin Chen (justschen)
approved these changes
Sep 8, 2026
Logan Ramos (lramos15)
deleted the
lramos15/agents/auto-tier-sdk-switching
branch
September 8, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333809.
Summary
setModel, alongside reasoning effort and context size. Send explicitnullto reset Auto routing preferences; omit the option for concrete models.setModel.Auto preference changes are staged by the runtime and commit on a later successful Auto turn; an accepted
setModelrequest is not treated as immediate activation.Dependency and history
#334606 has merged into
main, supplying SDK1.0.13and runtime1.0.84-2. This PR contains only the Auto-tier feature changes and focused CI fixes onmain; the already-merged dependency commits are no longer part of the PR commit list, and dependency upgrades are not included in the diff.Implementing PRs
Validation
npm run transpile-clientpassed.npm run typecheckpassed across all four TypeScript projects.5c8c130ffcf. Code OSS run 34272648088 completed successfully, including both Copilot jobs and Linux Remote.(Written by Copilot)