/await:strict and fixes for it#6240
Merged
Merged
Conversation
JohnMcPMS
added
the
Next-Release
florelis
previously approved these changes
May 21, 2026
Contributor
|
CPPwinRT 3.0 is now released, so the Props updates can be removed and the upgrade can happen |
Member
|
Now that the MSVC Build Tools 14.51 have shipped with my "hard deprecation" of the |
Contributor
I observed this as well. Specifically, VS2026 18.5.3 works to build the solution while 18.7.2 fails |
# Conflicts: # src/AppInstallerCommonCore/HttpStream/HttpClientWrapper.cpp # src/AppInstallerCommonCore/HttpStream/HttpClientWrapper.h # src/AppInstallerCommonCore/HttpStream/HttpLocalCache.cpp # src/AppInstallerCommonCore/HttpStream/HttpLocalCache.h # src/AppInstallerCommonCore/HttpStream/HttpRandomAccessStream.cpp # src/WindowsPackageManager/ConfigurationStaticFunctions.cpp
ranm-msft
approved these changes
Jul 11, 2026
florelis
removed
the
Next-Release
florelis
added a commit
that referenced
this pull request
Jul 14, 2026
## 📖 Description <!-- Describe what this PR changes, why, and any limitations. --> This is a follow up to #6240 When I updated the cppwinrt nuget version, the paths in the projects changed from `$(SolutionDir)\packages` to `..\packages`, which is correct in this repo, but it breaks when we pull it to the internal copy. This PR fixes that. ## 🔗 References <!-- Link related issues, PRs, or docs. Use "Resolves #1234" to auto-close. --> ## 🔍 Validation <!-- How did you test? List manual steps or note automated test coverage. --> ## ✅ Checklist <!-- Place an "x" between the brackets to check an item. e.g: [x] --> - [ ] Signed the [Contributor License Agreement](https://cla.opensource.microsoft.com) - [ ] Linked to an issue - [ ] Updated [Release Notes](../doc/ReleaseNotes.md) (if applicable) - [ ] Updated documentation (if applicable) - [ ] Updated [Copilot instructions](.github/copilot-instructions.md) (if build, architecture, or conventions changed) ## 📋 Issue Type <!-- Select the type that best describes this PR --> - [ ] Bug fix - [ ] Feature - [ ] Task ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/6365)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
/awaitis deprecated; this change removes the CppWinRT injected/awaitand replaces it with/await:strict. When CppWinRT 3.0 is released, we can remove the build props and it should handle things./await:strictcaused a few breaks that are also fixed in this PR, namely:returninstead ofco_returnstd::futurein coroutines that is no longer supported inherently; converted toIAsync*types so CppWinRT coroutine support handles them🔍 Validation
Builds locally, regression tests to ensure functionality.
Microsoft Reviewers: Open in CodeFlow