feat: Support limited search for added file #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we know that a file was added in a range of commits (typically something like origin/main..HEAD), we don't need to search the entire repo history for the file. This can yield significant speedups in large repos.
ecraig12345
reviewed
Jul 21, 2022
| */ | ||
| export function getFileAddedHash(filename: string, cwd: string) { | ||
| const results = git(["rev-list", "HEAD", filename], { cwd }); | ||
| export function getFileAddedHash(filename: string, cwd: string, fromRef?: string, toRef?: string) { |
Member
There was a problem hiding this comment.
I think it might be better to combine these in a single parameter, like range?: { fromRef: string; toRef: string }. That way it's clear that both fromRef and toRef are required, and (in some sense) reduces signature bloat.
Member
There was a problem hiding this comment.
Also, if you merge/rebase this, the function moved to src/git/gitUtilities.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know that a file was added in a range of commits (typically
something like origin/main..HEAD), we don't need to search the entire
repo history for the file. This can yield significant speedups in large
repos.