fix(main): URL-encode commas in image_with_width_with_height_with_fitting_mode() URL template#1551
Open
GokulSudheesh wants to merge 1 commit into
Open
fix(main): URL-encode commas in image_with_width_with_height_with_fitting_mode() URL template#1551GokulSudheesh wants to merge 1 commit into
GokulSudheesh wants to merge 1 commit into
Conversation
…ting_mode() URL template
Author
|
@jingjingjia-ms please take a look when you get the time, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue Description
The generated URL template for
image_with_width_with_height_with_fitting_mode() used literal commas
to separate the width, height, and fittingMode parameters in the template URL
image(width={width},height={height},fittingMode='{fittingMode}')Unencoded commas here caused the request to fail. The comas were getting omitted while making the actual request. Encoding them as
%2C resolves the issue:
image(width={width}%2Cheight={height}%2CfittingMode='{fittingMode}')