Skip to content

🔧 replace husky with prek - #499

Merged
ianardee merged 3 commits into
mainfrom
use-prek
Sep 30, 2026
Merged

ianardee merged 3 commits into
mainfrom
use-prek

Conversation

@ianardee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Hook installation is incomplete, license enforcement is removed, and Gitleaks scans no content in clean CI checkouts.

Review effort: Balanced
Findings: 2 High severity · 2 Medium severity

Open (4)
What changed in this PR

Replaces Husky and Secretlint with prek-managed hooks and Gitleaks.

Changes:

  • Adds prek hook configuration.
  • Removes Husky hooks and dependencies.
  • Consolidates static-analysis checks under prek.
File Description
prek.toml Defines TypeScript, package, and secret checks.
package.json Replaces hook dependencies with prek.
package-lock.json Adds prek and platform packages.
.husky/​pre-push Removes the pre-push hook.
.husky/​pre-commit Removes the pre-commit hook.
.github/​workflows/​_static-analysis.yml Runs prek and documentation checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
Comment thread prek.toml Outdated
Comment thread .github/workflows/_static-analysis.yml
Comment thread prek.toml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Hook installation is missing, and the CI Gitleaks hook does not scan the repository.

Review effort: Balanced
Findings: None

Resolved since last review (4)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Hook installation, CI secret scanning, and pre-push check coverage are currently incomplete.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Local hooks are not installed automatically, and the CI Gitleaks hook scans no files on a clean checkout.

Review effort: Balanced
Findings: 1 High severity

Open (1)
Resolved since last review (1)

Comment thread .github/workflows/_static-analysis.yml
@ianardee
ianardee force-pushed the use-prek branch 2 times, most recently from 89b8224 to 122123c Compare September 30, 2026 13:30
@ianardee
ianardee requested a balanced review from Copilot September 30, 2026 13:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Hook installation and pre-push checks are not preserved, while Betterleaks CI needs reproducible versioning and complete Git history.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)
Resolved since last review (1)

Comment thread .github/workflows/_static-analysis.yml
Comment thread .github/workflows/_static-analysis.yml
Update Betterleaks action version to v1.9.0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Fresh installations do not activate prek, and the former pre-push documentation and test checks are no longer configured.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ianardee
ianardee merged commit 4d9dec1 into main Sep 30, 2026
21 of 23 checks passed
@ianardee
ianardee deleted the use-prek branch September 30, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants