Repository navigation
Conversation
The German word list gave polarity to discourse particles and ordinary nouns
("ja", "bitte", "sicher", "Kinder", "Art"), so neutral or critical messages
scored as positive, while common profanity and complaints were missing.
- Ignore discourse particles and nouns that carry no sentiment of their own.
- Price words such as "teuer" are a complaint, not praise.
- Add frequent German and Austrian dialect profanity, insults, complaints and
inflected positives that were missing.
- Insults and profanity are not reversed by nearby negation ("ned so deppat"
stays negative).
Evaluated offline against model-labelled German chat: on messages with a
score, accuracy and coverage rose and polarity reversals fell. Regression
tests cover particles, new vocabulary and negated insults.
J0s3f
marked this pull request as ready for review
October 8, 2026 12:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the tool on a mid size German Discord server and found a few issues. I fixed them:
Text messages without recognized sentiment terms currently serialize an unavailable score through
NaNas byte zero. Both message readers turn that into-128, so an export with many unscored messages can appear overwhelmingly negative. This change preserves score availability through serialization and shows unscored coverage explicitly.not only/nicht nurexception. Matching no longer allocates a sliced token array at every word.Compatibility: legacy byte zero cannot distinguish an unavailable score from a genuine score saturated at
-128. Regenerating from the export resolves that ambiguity. New valid scores clamp to[-127, 127].