fix(server): don't crash registerAppTool when config._meta is omitted - #775
Open
er-s-an wants to merge 1 commit into
Open
fix(server): don't crash registerAppTool when config._meta is omitted#775er-s-an wants to merge 1 commit into
er-s-an wants to merge 1 commit into
Conversation
ToolConfig._meta is optional (_meta?), but the UI-metadata normalization
read config._meta.ui unconditionally, so registering a UI-less tool via
registerAppTool threw TypeError: Cannot read properties of undefined
(reading 'ui') on the first request.
Default to {} before normalizing. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guard the UI-metadata normalization in
registerAppToolwithconfig._meta ?? {}.Why
ToolConfig._metais typed optional (_meta?), butregisterAppToolreadconfig._meta.uiunconditionally. Registering a tool without UI metadata — a valid use, since not every tool on an MCP Apps server renders a view — crashed on the first request:Repro:
Changes
src/server/index.ts: defaultconfig._metato{}before normalizationsrc/server/index.test.ts: regression test — registering without_metasucceeds and passes_meta: {}throughbun test src/server/index.test.ts→ 16 pass, 0 fail.