-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Logging updates (including reported SonicBoom error) #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BobDickinson
wants to merge
3
commits into
modelcontextprotocol:v1.5/main
Choose a base branch
from
BobDickinson:logging-cleanup
base: v1.5/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,30 @@ | ||
| import path from "node:path"; | ||
| import pino from "pino"; | ||
| import type { Logger } from "pino"; | ||
| import { | ||
| silentLogger, | ||
| createFileLogger, | ||
| } from "@modelcontextprotocol/inspector-core/logging/node"; | ||
|
|
||
| const logDir = | ||
| process.env.MCP_INSPECTOR_LOG_DIR ?? | ||
| path.join( | ||
| process.env.HOME || process.env.USERPROFILE || ".", | ||
| ".mcp-inspector", | ||
| ); | ||
| const logPath = path.join(logDir, "auth.log"); | ||
| /** | ||
| * TUI logger (InspectorClient events, auth, etc.). | ||
| * File logger when MCP_LOG_FILE is set, else silentLogger. | ||
| */ | ||
| export let tuiLogger: Logger = silentLogger; | ||
|
|
||
| /** | ||
| * TUI file logger for auth and InspectorClient events. | ||
| * Writes to ~/.mcp-inspector/auth.log so TUI console output is not corrupted. | ||
| * The app controls logger creation and configuration. | ||
| * If MCP_LOG_FILE is set, creates a file logger (awaits destination ready); | ||
| * otherwise uses silentLogger. Call at the start of runTui() before any work | ||
| * that might call process.exit(). | ||
| */ | ||
| export const tuiLogger = pino( | ||
| { | ||
| name: "mcp-inspector-tui", | ||
| level: process.env.LOG_LEVEL ?? "info", | ||
| }, | ||
| pino.destination({ dest: logPath, append: true, mkdir: true }), | ||
| ); | ||
| export async function initTuiLogger(): Promise<void> { | ||
| if (process.env.MCP_LOG_FILE) { | ||
| tuiLogger = await createFileLogger({ | ||
| dest: process.env.MCP_LOG_FILE, | ||
| append: true, | ||
| mkdir: true, | ||
| level: "info", | ||
| name: "mcp-inspector-tui", | ||
| }); | ||
| } else { | ||
| tuiLogger = silentLogger; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Silent logger for browser contexts. Satisfies pino.Logger; does not output anything. | ||
| * Use when no logger is passed (e.g. OAuth callback with no client). Web components | ||
| * that need a fallback import from logging/browser so they don't pull in Node logging. | ||
| */ | ||
| // @ts-expect-error - pino/browser.js exists but TypeScript doesn't have types for the .js extension | ||
| import pino from "pino/browser.js"; | ||
| import type { Logger } from "pino"; | ||
|
|
||
| export const silentLogger: Logger = pino({ level: "silent" }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core/auth/index.tsis part of the package’s default (isomorphic) auth entrypoint (exports["./auth"]). Re-exportingsilentLoggerfrom../logging/nodemakes every import of@modelcontextprotocol/inspector-core/auth/auth/*pull in the Node logging module (and itspinoNode entry), which can break browser bundling even whensilentLoggeris not used. Consider removing this re-export from the shared auth index and instead exporting it fromauth/node(and/orauth/browser) or requiring callers to import fromlogging/nodevslogging/browserdirectly.