refactor: code style improvements and formatting cleanup#1962
Merged
Conversation
- Simplify multi-line context managers to single lines where readable - Use logger.exception() instead of logger.error() for exception logging - Remove redundant Args sections from internal method docstrings - Simplify _validate_content_type to a single return statement - Use Field(default_factory=list) for mutable defaults in Pydantic models - Convert Field descriptions to class-level docstrings Co-Authored-By: Claude Opus 4.5 <[email protected]>
Kludex
commented
Jan 27, 2026
Comment on lines
+219
to
+220
| except Exception: | ||
| logger.exception(f"Session {http_transport.mcp_session_id} crashed") |
Kludex
commented
Jan 27, 2026
Kludex
commented
Jan 27, 2026
Code reviewCode Changes: No issues found. The refactoring correctly improves code style and follows Python best practices. Process Issues: Two CLAUDE.md violations in PR metadata:
The code changes themselves are good - they improve exception logging ( |
maxisbey
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.