feat(utils): move channel flow utilities from modflow6#1668
Draft
wpbonelli wants to merge 1 commit intomodflowpy:developfrom
Draft
feat(utils): move channel flow utilities from modflow6#1668wpbonelli wants to merge 1 commit intomodflowpy:developfrom
wpbonelli wants to merge 1 commit intomodflowpy:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1668 +/- ##
=======================================
Coverage 71.4% 71.4%
=======================================
Files 253 253
Lines 55884 55884
=======================================
Hits 39946 39946
Misses 15938 15938 |
55672ea to
cbf727f
Compare
cbf727f to
0b6c5a5
Compare
0b6c5a5 to
b0d9733
Compare
6d1f8d6 to
fea25ad
Compare
fea25ad to
1afdd5c
Compare
jdhughes-dev
approved these changes
Jan 20, 2023
Contributor
jdhughes-dev
left a comment
There was a problem hiding this comment.
I am not sure anyone that uses flopy will need channel_utils but at least it is more available in flopy than in the mf6 repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move open channel flow utility functions from MODFLOW 6 to new file
flopy/utils/channel_utils.py. These were originally in modflow6'sautotest/scripts/cross_section_functions.py.Functions are included for
Discharge can be calculated for rectangular channels given width and height, as well as for more complex channel cross sections given a set of contiguous segments making up the channel bed.
This PR follows up on #1621 with a view to moving modeling-related utilities to
flopy