feat: add Docker Cache cleaning category (#1) by MukundaKatta · Pull Request #36 · momenbasel/PureMac

MukundaKatta · 2026-04-15T06:00:09Z

Summary

Closes #1.

Adds a new `dockerCache` `CleaningCategory` so users with Docker Desktop installed can recover space without leaving PureMac.

What it scans

On-disk caches under the Docker Desktop sandbox:
- `~/Library/Containers/com.docker.docker/Data/{cache,log,tmp}`
- `~/Library/Group Containers/group.com.docker/Caches`
- `~/.docker/cli-plugins/.cache`
- `~/.docker/buildx/cache`
Reclaimable space via the `docker` CLI:
- Runs `docker system df --format '{{.Reclaimable}}'` if `docker` is on PATH (Homebrew or `/usr/local/bin`).
- Surfaces the parsed total as an unselected virtual entry. The user runs `docker system prune -af` themselves — we just display how much they could recover.

Pattern

Mirrors the existing `scanBrewCache()` implementation:

Probe well-known paths first, fall through cleanly if Docker isn't installed.
Never touch anything outside the user's container sandbox.
Default to `isSelected: true` for cache directories that PureMac can safely delete itself; default to `false` for the CLI-managed reclaimable virtual entry.

Localization

Added entries for both `en.lproj` and `zh-Hans.lproj`:

"Docker Cache"
"Docker images, containers, and build cache"
"Reclaimable (run `docker system prune -af`)"

Test plan

`xcodebuild -project PureMac.xcodeproj -scheme PureMac -configuration Debug build` — succeeds.
All existing `CleaningCategory` switches updated (Models, ScanEngine).
No new dependencies.

AI-assisted disclosure

Drafted with Claude Code. I read the existing brew/xcode scanners to match the pattern, verified the Docker Desktop on macOS path layout, and built the project locally to confirm the new switch case compiles. I understand what the code does.

momenbasel · 2026-04-18T07:27:32Z

@copilot resolve the merge conflicts in this pull request

Copilot

Pull request overview

Adds a new “Docker Cache” cleaning category to PureMac, intended to surface Docker Desktop cache directories plus an informational “reclaimable space” entry derived from the docker CLI.

Changes:

Add dockerCache to CleaningCategory with icon/color/description.
Add Docker cache scanning to ScanEngine (well-known on-disk paths + optional docker system df reclaimable parsing).
Add localization keys for Docker strings in en and zh-Hans.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File	Description
PureMac/Services/ScanEngine.swift	Adds `scanDockerCache()`, plus CLI-based reclaimable-space parsing helpers.
PureMac/Models/Models.swift	Introduces `.dockerCache` enum case + associated UI metadata (icon/description/color).
PureMac/en.lproj/Localizable.strings	Adds English localization keys for Docker Cache strings.
PureMac/zh-Hans.lproj/Localizable.strings	Adds Simplified Chinese localization keys for Docker Cache strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-18T07:28:20Z

+        let dockerBinPaths = ["/usr/local/bin/docker", "/opt/homebrew/bin/docker"]
+        for dockerBin in dockerBinPaths where fileManager.fileExists(atPath: dockerBin) {
+            if let reclaimable = reclaimableDockerSpace(dockerBin: dockerBin), reclaimable > 0 {


PR description says the CLI check runs when docker is “on PATH”, but the implementation only checks two hard-coded locations (/usr/local/bin/docker, /opt/homebrew/bin/docker). If Docker is installed elsewhere (e.g., symlinked into a different directory), reclaimable space won’t be surfaced. Consider resolving via which docker//usr/bin/env docker (while still keeping the allowlist if desired).

Copilot · 2026-04-18T07:28:20Z

+        for dockerBin in dockerBinPaths where fileManager.fileExists(atPath: dockerBin) {
+            if let reclaimable = reclaimableDockerSpace(dockerBin: dockerBin), reclaimable > 0 {
+                items.append(CleanableItem(
+                    name: "Reclaimable (run `docker system prune -af`)",


This label is hard-coded English even though corresponding keys were added to Localizable.strings. Since this value is passed around as a String (not a LocalizedStringKey), it won’t be localized at render time—prefer String(localized: "Reclaimable (run …)") (or NSLocalizedString) here so the new translations are actually used.

Suggested change

name: "Reclaimable (run `docker system prune -af`)",

name: String(localized: "Reclaimable (run `docker system prune -af`)"),

Copilot · 2026-04-18T07:28:20Z

+        let dockerBinPaths = ["/usr/local/bin/docker", "/opt/homebrew/bin/docker"]
+        for dockerBin in dockerBinPaths where fileManager.fileExists(atPath: dockerBin) {
+            if let reclaimable = reclaimableDockerSpace(dockerBin: dockerBin), reclaimable > 0 {
+                items.append(CleanableItem(
+                    name: "Reclaimable (run `docker system prune -af`)",
+                    path: dockerBin,
+                    size: reclaimable,
+                    category: .dockerCache,
+                    isSelected: false,
+                    lastModified: nil
+                ))


The “Reclaimable …” virtual item uses the docker executable path as its path. In the current cleaning flow, selected items are deleted by item.path (with a safety allowlist), so if this row ends up selected it will attempt to delete /usr/local/bin/docker or /opt/homebrew/bin/docker and then surface a “Skipped … unsafe path” error. This should be modeled as a non-deletable/virtual item (e.g., add an isVirtual/action field and have the UI/cleaner skip it), and avoid using an actual filesystem path that implies it can be removed.

Copilot · 2026-04-18T07:28:21Z

+            if let reclaimable = reclaimableDockerSpace(dockerBin: dockerBin), reclaimable > 0 {
+                items.append(CleanableItem(
+                    name: "Reclaimable (run `docker system prune -af`)",
+                    path: dockerBin,
+                    size: reclaimable,
+                    category: .dockerCache,
+                    isSelected: false,
+                    lastModified: nil
+                ))


isSelected: false on the reclaimable-space row won’t have the intended effect with the current selection model: AppState defaults to “selected unless in deselectedItems” and clears deselectedItems on every scan, without initializing it from CleanableItem.isSelected. As a result this new virtual row will appear selected by default (and may be included in “Select All” flows). Either wire CleanableItem.isSelected into deselectedItems initialization when storing scan results, or remove isSelected from scan outputs and manage selection consistently in one place.

Copilot · 2026-04-18T07:28:21Z

+    /// Sum the reclaimable bytes reported by `docker system df --format json`.
+    /// Returns nil when Docker isn't running or the command fails — callers
+    /// should treat that as "no reclaimable info available", not as an error.
+    private func reclaimableDockerSpace(dockerBin: String) -> Int64? {
+        let task = Process()
+        task.executableURL = URL(fileURLWithPath: dockerBin)
+        task.arguments = ["system", "df", "--format", "{{.Reclaimable}}"]
+        let stdoutPipe = Pipe()


Doc comment mismatch: this function says it parses output from docker system df --format json, but the code runs docker system df --format "{{.Reclaimable}}". Update the comment (or the command) so future maintainers don’t assume JSON parsing here.

Copilot · 2026-04-18T07:28:21Z

+                items.append(CleanableItem(
+                    name: "Reclaimable (run `docker system prune -af`)",
+                    path: dockerBin,
+                    size: reclaimable,
+                    category: .dockerCache,
+                    isSelected: false,
+                    lastModified: nil
+                ))


The item name includes backticks (`docker system prune -af`). SwiftUI Text doesn’t render Markdown, so these backticks will show up literally in the UI. Consider removing the backticks (or presenting the command in a separate UI affordance like a copy button) to avoid confusing display text.

Copilot · 2026-04-18T07:28:21Z

+/* Docker Cache */
+"Docker Cache" = "Docker Cache";
+"Docker images, containers, and build cache" = "Docker images, containers, and build cache";
+"Reclaimable (run `docker system prune -af`)" = "Reclaimable (run `docker system prune -af`)";


These new Docker strings are only added for en and zh-Hans, but the repo also ships zh-Hant.lproj/Localizable.strings. Without adding equivalent keys there, users in that locale will see fallback/English for the new Docker UI strings. Consider adding the same three keys to zh-Hant (and any other supported locales) to keep localization coverage consistent.

Copilot · 2026-04-18T07:28:21Z

+/* Docker Cache */
+"Docker Cache" = "Docker 缓存";
+"Docker images, containers, and build cache" = "Docker 镜像、容器和构建缓存";
+"Reclaimable (run `docker system prune -af`)" = "可回收空间（运行 `docker system prune -af`）";


The string includes backticks (`docker system prune -af`). If this is shown in a normal label, backticks will appear literally (no code formatting). Consider removing the backticks or adjusting the presentation so the command is shown in a clearer way.

Suggested change

"Reclaimable (run `docker system prune -af`)" = "可回收空间（运行 `docker system prune -af`）";

"Reclaimable (run docker system prune -af)" = "可回收空间（运行 docker system prune -af）";

Adds a new `dockerCache` CleaningCategory that scans the Docker Desktop on macOS install for recoverable space: - Scans on-disk caches under `~/Library/Containers/com.docker.docker/Data/{cache,log,tmp}`, `~/Library/Group Containers/group.com.docker/Caches`, and the `~/.docker/{cli-plugins/.cache,buildx/cache}` user-tree caches. - If the `docker` CLI is on PATH (Homebrew or /usr/local), invokes `docker system df --format '{{.Reclaimable}}'` and surfaces the total reclaimable bytes as an *unselected* virtual entry — the user's expected to run `docker system prune -af` themselves; we just display the magnitude. The same pattern as the existing brewCache scanner: probe well-known paths, fall back gracefully if Docker isn't installed, never hit anything outside the user's container sandbox. Localized strings added for both en and zh-Hans. Closes momenbasel#1

momenbasel requested a review from Copilot April 18, 2026 07:23

Copilot started reviewing on behalf of momenbasel April 18, 2026 07:23 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

MukundaKatta force-pushed the feat/docker-cache-category branch from f21b095 to eddda08 Compare April 18, 2026 09:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Docker Cache cleaning category (#1)#36

feat: add Docker Cache cleaning category (#1)#36
MukundaKatta wants to merge 1 commit intomomenbasel:mainfrom
MukundaKatta:feat/docker-cache-category

MukundaKatta commented Apr 15, 2026

Uh oh!

momenbasel commented Apr 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	name: "Reclaimable (run `docker system prune -af`)",
	name: String(localized: "Reclaimable (run `docker system prune -af`)"),

	"Reclaimable (run `docker system prune -af`)" = "可回收空间（运行 `docker system prune -af`）";
	"Reclaimable (run docker system prune -af)" = "可回收空间（运行 docker system prune -af）";

Conversation

MukundaKatta commented Apr 15, 2026

Summary

What it scans

Pattern

Localization

Test plan

AI-assisted disclosure

Uh oh!

momenbasel commented Apr 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants