command: add support for using playlist entry id for several playlist management commands - #18267
Open
na-na-hi wants to merge 8 commits into
Open
command: add support for using playlist entry id for several playlist management commands#18267na-na-hi wants to merge 8 commits into
na-na-hi wants to merge 8 commits into
Conversation
Will be used in later commits for commands using playlist entry id.
This prevents overflow when specifying very large index values in later commits.
Add id flag which makes it use playlist entry id specified by the optional second argument for manipulation. This also removes the roundtrip entry->index->entry conversion when "current" is used as pos.
Only 0,1,2,3,8 are read by get_load_action.
Add id flag which makes it interprets index parameter as playlist entry id.
Add id flag which makes it use playlist entry id specified by the optional second argument for manipulation.
Add a flag which makes it use playlist entry id for the index arguments.
Member
|
I would like to merge #17458 before this one, for the interface simplification. |
Contributor
Author
That PR is incompatible with the API design of the current PR, specifically: {"index", OPT_INT(v.i),
M_RANGE(LOAD_POS_NONE, INT_MAX), OPTDEF_INT(LOAD_POS_NONE)},The current PR changes the type of this argument to |
Member
It should be possible to change the range here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using playlist entry id for several playlist management commands (
playlist-play-index/loadfile/loadlist/playlist-remove/playlist-move).This allows the entry to be manipulated specified by its playlist entry id, which does not change when other playlist items are changed or shuffled, so it resolves a race condition when the playlist is changed by another client while one client is finding the index of a specific item.
Fixes: #10082