Specify that group-exchange is unsupported for server, and don't use it as a default - #1512
Open
roy-trgscreen wants to merge 2 commits into
Open
Specify that group-exchange is unsupported for server, and don't use it as a default#1512roy-trgscreen wants to merge 2 commits into
roy-trgscreen wants to merge 2 commits into
Conversation
Clarify that certain algorithms are not supported when running as server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running as server, and having a
group-exchangekex in your list, kex negotiation can fail even if there is a compatible one, as the server will advertise supportingdiffie-hellman-group-exchange-sha256, but then after it was chosen authentication will fail, even if there are lower priority kex options that would work (as group-exchange is not implemented for the server:ssh2/lib/protocol/kex.js
Lines 1439 to 1446 in a3a39d7
Clarify that certain algorithms are not supported when running as server, and also not choose them by default.
I would potentially even go as far as to filter out user-specified
-group-exhange-options so users don't fall into the same trap as I did.