Fix task execution for certain configurations#1
Open
Conversation
alex-bach
force-pushed
the
feature/BCV-1
branch
from
08f5793 to
f425a3e
Compare
poseidon-mysugr
approved these changes
Mar 15, 2021
poseidon-mysugr
left a comment
poseidon-mysugr
left a comment
There was a problem hiding this comment.
LGTM, but I'd remove all changes except the fix itself before opening a PR against upstream.
| project.tasks.getByName("check").dependsOn(apiCheck) | ||
| } | ||
|
|
||
| // the task handed to isSatisfiedBy is never used, so it does not matter what we hand over. |
There was a problem hiding this comment.
I think passing this is actually the correct task. The gradle api is old java code, so this is intended to be some class in some other file, hence they pass the Task into the callback. with kotlin you almost never need it, because if used with a lambda, you capture it anyways. TL/DR: I'd just remove that comment.
alex-bach
force-pushed
the
feature/BCV-1
branch
2 times, most recently
from
2bf8b7f to
02527d0
Compare
alex-bach
force-pushed
the
feature/BCV-1
branch
from
02527d0 to
d8d7331
Compare
whether tasks should be executed. This fixes a bug where tasks would not be executed, because srcDirs would not yet exist at configuration time.
alex-bach
force-pushed
the
feature/BCV-1
branch
from
d8d7331 to
cb69686
Compare
alex-bach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is not JIRA page yet to document the issues.