-
Notifications
You must be signed in to change notification settings - Fork 16
Omnigraph Refactor (cont) #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
faa8b61
991eb47
54ba073
bb3c157
d58999f
d9637fc
066cf12
a0c1162
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensapi": minor | ||
| --- | ||
|
|
||
| Omnigraph API (BREAKING): Removed `ENSv2Domain.canonicalId`. | ||
shrugs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,5 @@ | ||||||
| --- | ||||||
| "ensapi": minor | ||||||
|
||||||
| "ensapi": minor | |
| "ensapi": major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset describes a breaking API surface change (removing
ENSv2Domain.canonicalId) but bumpsensapiasminor. If consumers rely on the GraphQL schema andensapiis semver-stable (1.x), consider using amajorbump (or clarify why this is intentionally a minor bump).