feat: shareScope 'auto'#77
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #76
This pull request introduces a new feature for version-pinned share scopes in module federation, allowing shared dependencies to be isolated by version using the new
autoShareScopeutility. This makes it easier to ensure that only compatible versions of dependencies are shared between remotes, reducing the risk of version conflicts. The implementation includes documentation, code, and comprehensive tests.Key changes:
New Feature: Version-Pinned Share Scopes
Added the
autoShareScopeutility function andPackageShareScopeOptionstype tosrc/config/share-utils.ts, enabling automatic generation of share scope names based on a dependency's version (e.g.,"ng21.1"). This supports configurable granularity (major,minor,patch), custom dependency selection, and custom prefixes.Updated the documentation in
README.mdto describe the new version-pinned share scopes feature, including usage examples and configuration options.API and Exports
autoShareScopeandPackageShareScopeOptionsfrom the package entrypoint insrc/config.ts.Testing
autoShareScopeinsrc/config/share-utils.spec.ts, covering version extraction, granularity options, dependency fallbacks, and error cases.fsmethods in the test suite to simulate variouspackage.jsonscenarios for robust test coverage.Miscellaneous
tsconfig.tsbuildinfoartifact.